Sign personal #27
Merged
Sign personal #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chcmedeiros
force-pushed
the
sign_personal
branch
3 times, most recently
from
07ba6b1 to
cab2641
Compare
0xPxt
approved these changes
Nov 29, 2024
emmanuelm41
approved these changes
Nov 29, 2024
app/src/evm/parser_impl_eth.c
Outdated
| uint8_t parity = (info & CX_ECCINFO_PARITY_ODD) == 1; | ||
| if (personal_msg) { | ||
| *v = 27 + parity; |
There was a problem hiding this comment.
this number seems like magic here. It would be great if we convert it to some CONST
chcmedeiros
force-pushed
the
sign_personal
branch
from
cab2641 to
692ab42
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.