Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #30

Merged
merged 4 commits into from
Dec 6, 2024
Merged

Fix #30

merged 4 commits into from
Dec 6, 2024

Conversation

chcmedeiros
Copy link
Contributor

No description provided.

emmanuelm41
emmanuelm41 approved these changes Dec 6, 2024
View reviewed changes
Copy link
Member

@emmanuelm41 emmanuelm41 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would be great if we add a test case to cover this specific bug that we are fixing!

@chcmedeiros
Copy link
Contributor Author

I would be great if we add a test case to cover this specific bug that we are fixing!

Great idea! Just added !

@chcmedeiros chcmedeiros merged commit cb21225 into dev Dec 6, 2024
34 checks passed
@chcmedeiros chcmedeiros deleted the fix branch December 6, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emmanuelm41 emmanuelm41 emmanuelm41 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chcmedeiros @emmanuelm41