Feat/evm #5
Merged
Feat/evm #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| parser_error_t _validateTxEth(); | ||
|
|
||
| // parser_error_t _computeV(unsigned int info, uint8_t *v); |
Check notice
Code scanning / CodeQL
Commented-out code Note
ftheirs
reviewed
Jan 17, 2024
| #include "zxmacros.h" | ||
|
|
||
| uint32_t hdPath[HDPATH_LEN_DEFAULT]; | ||
| uint32_t hdPath_len; |
There was a problem hiding this comment.
hdPath should be at least 10 (MAX_BIP32_PATH)
ftheirs
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.