Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev #7

Merged
merged 7 commits into from
Mar 1, 2024
Merged

Dev #7

merged 7 commits into from
Mar 1, 2024

Conversation

chcmedeiros
Copy link
Contributor

No description provided.

@chcmedeiros chcmedeiros requested a review from ftheirs February 28, 2024 19:26
ftheirs
ftheirs approved these changes Mar 1, 2024
View reviewed changes
Copy link

@ftheirs ftheirs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 🚀 Can you update the apdu specs to match all the current commands and params (and also which derivation paths are allowed)

@chcmedeiros chcmedeiros merged commit ffc9ce3 into main Mar 1, 2024
43 checks passed
@chcmedeiros chcmedeiros deleted the dev branch March 8, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ftheirs ftheirs ftheirs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chcmedeiros @ftheirs