Menu refactor #16
Merged
Menu refactor #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this commit includes creating the `menu` package and abstracting the branch list functionality and associated hotkeys to its own file
move help into modal because the functionality is the same
this includes new keybindings and abstracting the git component features
previously broom was using the go-git method `DeleteBranches` which deletes branches that are present in `.git/config`. This was causing unexpected behavior since branches are only in `.git/config` if there is a remote referfence to track with the local branch. This commit removes the use of `DeleteBranches` in favor of `RemoveReferences` which instead deletes the specific reference from the git store.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ITS ABOUT TIME
fixes #10