-
-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for DSSP version and add rsa node features to residues with insertion codes #355
Conversation
Thanks @biochunan LGTM! Only comment re: pdb files - I'm quite sure these can be uploaded uncompressed. See: https://github.com/a-r-j/graphein/tree/master/tests/protein/test_data |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Will merge once tests pass. I think uploading the PDB (or using an existing file in test_data/
should work).
On second thought, it's likely the |
Hi @a-r-j thanks for going through the PR. |
I had a look at the three pdb files in tests/protein/test_data, and they do not have insertion code. Maybe it's a good idea to add a PDB file with insertion codes for |
for more information, see https://pre-commit.ci
…r/biochunan/355
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Kudos, SonarCloud Quality Gate passed!
|
…s which were filtered out in G.graph['pdb_df']
…f insertions, e.g. 100 and 100E in pdb2qad_1P.mar
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #355 +/- ##
==========================================
+ Coverage 40.27% 45.07% +4.80%
==========================================
Files 48 113 +65
Lines 2811 7916 +5105
==========================================
+ Hits 1132 3568 +2436
- Misses 1679 4348 +2669 ☔ View full report in Codecov by Sentry. |
Reference Issues/PRs
Fixes Issue #353
Fixes Issue #354
What does this implement/fix? Explain your changes
For Issue #353, this PR added a line to determine
dssp
version, which is passed to the functionBio.PDB.DSSP.dssp_dict_from_pdb_file
otherwise, biopython will use default version number 3.9.9 and for users with dssp version >= 4.0.0, this will lead to an empty dssp DataFrameFor Issue #354, this modification fixes errors caused by missing
rsa
feature from nodes with insertion code. This is caused by skipping insertions when creatingnode_id
. This modifications adds insertion codes tonode_id
ifinsertions
is set toTrue
inProteinGraphConfiguration
.What testing did you do to verify the changes in this PR?
Added a script
test_dssp.py
to tests/featuresThe example input pdb file (with cryst1 line and insertion codes) is attached here: input_pdb_cryst1.pdb.gz
File with suffix
.pdb
is not supported by GitHub, thus the compressed version. Need to uncompress it first before running the test.Pull Request Checklist
./CHANGELOG.md
file (if applicable)./graphein/tests/*
directories (if applicable)./notebooks/
(if applicable)python -m py.test tests/
and make sure that all unit tests pass (for small modifications, it might be sufficient to only run the specific test file, e.g.,python -m py.test tests/protein/test_graphs.py
)black .
andisort .