Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/logging cif support #402

Merged
merged 19 commits into from
Aug 2, 2024
Merged

Feat/logging cif support #402

merged 19 commits into from
Aug 2, 2024

Conversation

kierandidi
Copy link
Collaborator

Reference Issues/PRs

What does this implement/fix? Explain your changes

Add cif support for download and processing. Also disable logging by default and change a few logging statements from warning to debug

What testing did you do to verify the changes in this PR?

Pull Request Checklist

  • Added a note about the modification or contribution to the ./CHANGELOG.md file (if applicable)
  • Added appropriate unit test functions in the ./graphein/tests/* directories (if applicable)
  • Modify documentation in the corresponding Jupyter Notebook under ./notebooks/ (if applicable)
  • Ran python -m py.test tests/ and make sure that all unit tests pass (for small modifications, it might be sufficient to only run the specific test file, e.g., python -m py.test tests/protein/test_graphs.py)
  • Checked for style issues by running black . and isort .

@kierandidi kierandidi requested a review from a-r-j July 8, 2024 20:53
@kierandidi kierandidi self-assigned this Jul 8, 2024
@kierandidi kierandidi force-pushed the feat/logging_cif_support branch from dc01725 to 9859eb1 Compare July 8, 2024 20:54
@kierandidi kierandidi force-pushed the feat/logging_cif_support branch from bc67946 to 5a0d22a Compare July 14, 2024 14:48
@kierandidi kierandidi force-pushed the feat/logging_cif_support branch from ed47e2a to 00e2263 Compare July 19, 2024 10:51
Copy link

sonarqubecloud bot commented Aug 2, 2024

@a-r-j a-r-j merged commit 848a3f8 into master Aug 2, 2024
30 of 54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants