-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: config file support #2
Conversation
Add batch support for vllm
Signed-off-by: Kai Xu <[email protected]>
src/instructlab/sdg/default_flows.py
Outdated
block["block_config"]["convert_dtype"] = CONVERT_DTYPE_MAP[block["block_config"]["convert_dtype"]] | ||
n = self.num_instructions_to_generate | ||
if n is not None: | ||
if "gen_kwargs" in block: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this correct? or we only want to do this for the first block in the flow?
Signed-off-by: Kai Xu <[email protected]>
Signed-off-by: Kai Xu <[email protected]>
Signed-off-by: Kai Xu <[email protected]>
Signed-off-by: Kai Xu <[email protected]>
Signed-off-by: Aakanksha Duggal <[email protected]>
Signed-off-by: Kai Xu <[email protected]>
@@ -97,7 +97,9 @@ | |||
|
|||
ds = Dataset.from_list(samples) | |||
|
|||
skills_flow = SynthGroundedSkillsFlow(client, "mixtral", teacher_model, 10).get_flow() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that you have removed the fields for teacher_model and "mixtral" could you please help me understand how it is interacting with the teacher model.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"mixtral"
is the model family and teacher_model
is the model ID
- the model ID is defined in the YAML files as
model_id
- the model family is derived from the
model_id
by theMODEL_FAMILY_MAP
Signed-off-by: Kai Xu <[email protected]>
Signed-off-by: Kai Xu <[email protected]>
as of bd370b5, the CLI command below works
|
Signed-off-by: Kai Xu <[email protected]>
Tested this with @xukai92 - works as expected |
* feat: implement get_flow_from_file and port flows to YAML files Signed-off-by: Kai Xu <[email protected]> * refactor: remove code version of configs Signed-off-by: Kai Xu <[email protected]> * feat: introduce DEFAULT_FLOW_FILE_MAP Signed-off-by: Kai Xu <[email protected]> * chore: make linter happy Signed-off-by: Kai Xu <[email protected]> * format(tox) Signed-off-by: Kai Xu <[email protected]> * format(tox) Signed-off-by: Kai Xu <[email protected]> * fix: model ID for CLI test Signed-off-by: Kai Xu <[email protected]> * fix: model family map for CLI test Signed-off-by: Kai Xu <[email protected]> * feat: hard code samples in config files Signed-off-by: Kai Xu <[email protected]> --------- Signed-off-by: Kai Xu <[email protected]> Signed-off-by: Aakanksha Duggal <[email protected]> Co-authored-by: Aakanksha Duggal <[email protected]>
➕ Add transformers to reqs
tested by the code below: