-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add new tables and relations for user schema #26
Conversation
b224a5e
to
bc7d294
Compare
@aarbanas I finally had some time to look at the DB design and model. Overall I think we have a good model regarding everything. There are some additional stuff that I need to understand primarily it's the
If you have any questions we can talk about this on Discord so feel free to ping me 🚀! Everything else looks perfect, and my DB OCD likes it :P singular tables names with snake case naming convention :D |
@IMilja ty for the review 🚀
|
@aarbanas I've checked the PR a bit and I found one smaller issue with the address table. The |
@aarbanas Don't hate me 😢 I'm trying to not nitpick but we have another scenario in the profile_languages part. Primarily, I've noticed that we have multiple languages based on a level which in the end looks like this: This is not wrong, but, not ideal either because you have now 6 records per language in the DB. What I would suggest that we can look into is the following. We drop the level column from the One other benefit I can see later is an easier implementation of a feature where you can change the level (if you completed a course) because when you need to update a level you just need a |
@aarbanas everything else has my blessing 🚀. Nice first from 0 DB design!!! |
c69ee94
to
92014c7
Compare
Description
With this PR we've extended the existing user schema with new requirements from the client.
How to test
create database "red-cross-evidence"
Change summary
Checklist