Nas2 #32
Closed
Nas2 #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acacore/database/column.py
Outdated
| @@ -95,7 +87,7 @@ def _schema_to_column(name: str, schema: dict, defs: Optional[dict[str, dict]] = | |||
| elif schema_type in ("object", "array"): | |||
| sql_type = "text" | |||
| to_entry = lambda o: dumps(dump_object(o), default=str) | |||
| from_entry = lambda x: from_entry_func(x) | |||
| from_entry = lambda x: loads(x) if x else None | |||
There was a problem hiding this comment.
Det burde være:
None if x is in (None, '') else loads(x)Hvis du bruger bare if x, bliver alle "falsy" væredier (fx. 0) konverteret til None. Tomme strings og NULL værdier er okay, men alle de ændre, der ikke kan parses som JSON, burde raise en exception, fordi de returneres fra databasen kun hvis noget gik galt.
acacore/database/column.py
Outdated
| @@ -104,7 +96,7 @@ def _schema_to_column(name: str, schema: dict, defs: Optional[dict[str, dict]] = | |||
| if not schema_any_of[0] or len(schema_any_of) > 2: | |||
| sql_type = "text" | |||
| to_entry = lambda o: dumps(dump_object(o), default=str) | |||
| from_entry = lambda x: from_entry_func(x) | |||
| from_entry = lambda x: loads(x) if x else None | |||
|
No longer relevant. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.