Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#136: Move from qmake to CMake #166

Merged
merged 8 commits into from
Mar 9, 2024

Conversation

aaronhktan
Copy link
Owner

Description

This commit switches the project's build system from qmake to CMake.

Using CMake has several advantages:

  • Looking forward, Qt 6 uses CMake by default. It will be easier to migrate to Qt 6 with CMake as the default build system.
  • CMake is essentially an industry standard for C++ projects. This is a good learning opportunity, and because there are many people using CMake, it is easy to find resources for most edge-cases.
  • Automatic discovery of tests whose build system is CMake-by-default.

Part of a series of commits for #136.

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Tested by building debug builds on macOS, Windows, and Linux. Packaging for release has not yet been tested, and will be tested once a release is closer.

Checklist:

  • My code follows the style guidelines of this project (black for Python
    code, .clang-format in the src/jyut-dict directory for C++)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have translated my user-facing strings to all currently-supported languages
  • I have made corresponding changes to the documentation

@aaronhktan aaronhktan added the enhancement Improvement to existing feature label Mar 9, 2024
@aaronhktan aaronhktan added this to the 2024 Milestone 1 milestone Mar 9, 2024
@aaronhktan aaronhktan self-assigned this Mar 9, 2024
@aaronhktan aaronhktan merged commit 83e44f0 into main Mar 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement to existing feature
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant