add expiryDate message

abema · Nov 19, 2024 · 4f5775d · 4f5775d
1 parent 8546769
commit 4f5775d
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/flagfit-lint/src/main/java/tv/abema/flagfit/FlagTypeExpiryDateIllegalParamDetector.kt b/flagfit-lint/src/main/java/tv/abema/flagfit/FlagTypeExpiryDateIllegalParamDetector.kt
@@ -51,8 +51,9 @@ class FlagTypeExpiryDateIllegalParamDetector : Detector(), SourceCodeScanner {
     }
     if (expiryDate == FlagType.EXPIRY_DATE_NOT_DEFINED) return
     if (!isDateFormatValid(expiryDate)) {
-      val message = "The value of expireDate is not in the correct date format.\n" +
-        "Please set the expiration date in the following format: \"yyyy-mm-dd\""
+      val message =
+        "The value of expireDate is not in the correct date format. (expiryDate=$expiryDate)\n" +
+            "Please set the expiration date in the following format: \"yyyy-mm-dd\""
       context.report(ISSUE_ILLEGAL_DATE, element, location, message)
     }
   }
@@ -65,8 +66,9 @@ class FlagTypeExpiryDateIllegalParamDetector : Detector(), SourceCodeScanner {
   ) {
     when (qualifiedName) {
       AnnotationPackagePath.PACKAGE_PATH_WIP, AnnotationPackagePath.PACKAGE_PATH_EXPERIMENT -> {
-        val message = "`EXPIRY_DATE_INFINITE` cannot be set for the expireDate of `@FlagType.WorkInProgress` and `@FlagType.Experiment`.\n" +
-          "Please set the expiration date in the following format: \"yyyy-mm-dd\""
+        val message =
+          "`EXPIRY_DATE_INFINITE` cannot be set for the expireDate of `@FlagType.WorkInProgress` and `@FlagType.Experiment`.\n" +
+              "Please set the expiration date in the following format: \"yyyy-mm-dd\""
         context.report(ISSUE_ILLEGAL_EXPIRY_DATE_INFINITE_PARAM, element, location, message)
       }
 

diff --git a/flagfit-lint/src/test/java/tv/abema/flagfit/FlagTypeExpiryDateIllegalParamDetectorText.kt b/flagfit-lint/src/test/java/tv/abema/flagfit/FlagTypeExpiryDateIllegalParamDetectorText.kt
@@ -154,7 +154,7 @@ class FlagTypeExpiryDateIllegalParamDetectorText : LintDetectorTest() {
       .run()
       .expect(
         """
-        src/foo/Example.kt:12: Error: The value of expireDate is not in the correct date format.
+        src/foo/Example.kt:12: Error: The value of expireDate is not in the correct date format. (expiryDate=2023-12-100)
         Please set the expiration date in the following format: "yyyy-mm-dd" [FlagfitIllegalDate]
             @FlagType.Ops(
             ^