-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Use wrapper SDK proxy to track Chat SDK usage #211
base: main
Are you sure you want to change the base?
Conversation
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
57a8abb
to
79890bf
Compare
79890bf
to
4b3fb22
Compare
4b3fb22
to
3cfb0bd
Compare
3cfb0bd
to
2c70f80
Compare
2c70f80
to
08cfe03
Compare
So that we can use the wrapper SDK proxy functionality; TODO remove this commit once that's released
This implements ADR-117, and will allow us to track usage of the Chat SDK. TODO test TODO add to chat spec [1] https://ably.atlassian.net/wiki/spaces/ENG/pages/3413016589/ADR-117+Tracking+wrapper+SDK+usage+continued
Introduced in (TODO: insert version).
08cfe03
to
cb21da6
Compare
Note: This must not be merged until the functionality introduced in ably/ably-cocoa#2014 has been released.
This demonstrates the use of the new
-[ARTRealtime createWrapperSDKProxyWithOptions:]
method introduced in ably/ably-cocoa#2014, which implements ADR-117: Tracking wrapper SDK usage, continued, allowing us to track usage of the Chat SDK.Once I've written a specification for the API introduced in ably-cocoa, I will also add something to the chat spec to describe the behaviour implemented in the current PR.