Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip add channels property to ARTRealtimeProtocol #1966

Closed
wants to merge 1 commit into from
Closed

wip add channels property to ARTRealtimeProtocol #1966

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Source/PrivateHeaders/Ably/ARTRealtime+Private.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,12 @@
#import <Ably/ARTRealtimeTransport.h>
#import <Ably/ARTAuth+Private.h>
#import <Ably/ARTRest+Private.h>
#import <Ably/ARTRealtimeChannels+Private.h>

@class ARTRestInternal;
@class ARTErrorInfo;
@class ARTProtocolMessage;
@class ARTConnectionInternal;
@class ARTRealtimeChannelsInternal;

NS_ASSUME_NONNULL_BEGIN

Expand All @@ -30,7 +30,7 @@
@interface ARTRealtimeInternal : NSObject<ARTRealtimeProtocol>

@property (nonatomic, readonly) ARTConnectionInternal *connection;
@property (nonatomic, readonly) ARTRealtimeChannelsInternal *channels;

Check failure on line 33 in Source/PrivateHeaders/Ably/ARTRealtime+Private.h

View workflow job for this annotation

GitHub Actions / check (tvOS, test_tvOS17_2) 

unknown type name 'ARTRealtimeChannelsInternal'; did you mean 'ARTRestChannelsInternal'?

Check failure on line 33 in Source/PrivateHeaders/Ably/ARTRealtime+Private.h

View workflow job for this annotation

GitHub Actions / check (tvOS, test_tvOS17_2) 

property type 'ARTRestChannelsInternal * _Nonnull' is incompatible with type 'id<ARTRealtimeChannelProtocol> _Nonnull' inherited from 'ARTRealtimeProtocol' [-Werror,-Wincompatible-property-type]

Check failure on line 33 in Source/PrivateHeaders/Ably/ARTRealtime+Private.h

View workflow job for this annotation

GitHub Actions / check (tvOS, test_tvOS17_2) 

unknown type name 'ARTRealtimeChannelsInternal'; did you mean 'ARTRestChannelsInternal'?

Check failure on line 33 in Source/PrivateHeaders/Ably/ARTRealtime+Private.h

View workflow job for this annotation

GitHub Actions / check (tvOS, test_tvOS17_2) 

property type 'ARTRestChannelsInternal * _Nonnull' is incompatible with type 'id<ARTRealtimeChannelProtocol> _Nonnull' inherited from 'ARTRealtimeProtocol' [-Werror,-Wincompatible-property-type]

Check failure on line 33 in Source/PrivateHeaders/Ably/ARTRealtime+Private.h

View workflow job for this annotation

GitHub Actions / check 

unknown type name 'ARTRealtimeChannelsInternal'; did you mean 'ARTRestChannelsInternal'?

Check warning on line 33 in Source/PrivateHeaders/Ably/ARTRealtime+Private.h

View workflow job for this annotation

GitHub Actions / check 

property type 'ARTRestChannelsInternal * _Nonnull' is incompatible with type 'id<ARTRealtimeChannelProtocol> _Nonnull' inherited from 'ARTRealtimeProtocol' [-Wincompatible-property-type]

Check failure on line 33 in Source/PrivateHeaders/Ably/ARTRealtime+Private.h

View workflow job for this annotation

GitHub Actions / check 

unknown type name 'ARTRealtimeChannelsInternal'; did you mean 'ARTRestChannelsInternal'?

Check warning on line 33 in Source/PrivateHeaders/Ably/ARTRealtime+Private.h

View workflow job for this annotation

GitHub Actions / check 

property type 'ARTRestChannelsInternal * _Nonnull' is incompatible with type 'id<ARTRealtimeChannelProtocol> _Nonnull' inherited from 'ARTRealtimeProtocol' [-Wincompatible-property-type]

Check failure on line 33 in Source/PrivateHeaders/Ably/ARTRealtime+Private.h

View workflow job for this annotation

GitHub Actions / check (macOS, test_macOS) 

unknown type name 'ARTRealtimeChannelsInternal'; did you mean 'ARTRestChannelsInternal'?

Check failure on line 33 in Source/PrivateHeaders/Ably/ARTRealtime+Private.h

View workflow job for this annotation

GitHub Actions / check (macOS, test_macOS) 

property type 'ARTRestChannelsInternal * _Nonnull' is incompatible with type 'id<ARTRealtimeChannelProtocol> _Nonnull' inherited from 'ARTRealtimeProtocol' [-Werror,-Wincompatible-property-type]

Check failure on line 33 in Source/PrivateHeaders/Ably/ARTRealtime+Private.h

View workflow job for this annotation

GitHub Actions / check (macOS, test_macOS) 

unknown type name 'ARTRealtimeChannelsInternal'; did you mean 'ARTRestChannelsInternal'?

Check failure on line 33 in Source/PrivateHeaders/Ably/ARTRealtime+Private.h

View workflow job for this annotation

GitHub Actions / check (macOS, test_macOS) 

property type 'ARTRestChannelsInternal * _Nonnull' is incompatible with type 'id<ARTRealtimeChannelProtocol> _Nonnull' inherited from 'ARTRealtimeProtocol' [-Werror,-Wincompatible-property-type]

Check failure on line 33 in Source/PrivateHeaders/Ably/ARTRealtime+Private.h

View workflow job for this annotation

GitHub Actions / check (iOS, test_iOS17_2) 

unknown type name 'ARTRealtimeChannelsInternal'; did you mean 'ARTRestChannelsInternal'?

Check failure on line 33 in Source/PrivateHeaders/Ably/ARTRealtime+Private.h

View workflow job for this annotation

GitHub Actions / check (iOS, test_iOS17_2) 

property type 'ARTRestChannelsInternal * _Nonnull' is incompatible with type 'id<ARTRealtimeChannelProtocol> _Nonnull' inherited from 'ARTRealtimeProtocol' [-Werror,-Wincompatible-property-type]

Check failure on line 33 in Source/PrivateHeaders/Ably/ARTRealtime+Private.h

View workflow job for this annotation

GitHub Actions / check (iOS, test_iOS17_2) 

unknown type name 'ARTRealtimeChannelsInternal'; did you mean 'ARTRestChannelsInternal'?

Check failure on line 33 in Source/PrivateHeaders/Ably/ARTRealtime+Private.h

View workflow job for this annotation

GitHub Actions / check (iOS, test_iOS17_2) 

property type 'ARTRestChannelsInternal * _Nonnull' is incompatible with type 'id<ARTRealtimeChannelProtocol> _Nonnull' inherited from 'ARTRealtimeProtocol' [-Werror,-Wincompatible-property-type]
@property (readonly) ARTAuthInternal *auth;
@property (readonly) ARTPushInternal *push;
#if TARGET_OS_IOS
Expand Down
7 changes: 6 additions & 1 deletion Source/include/Ably/ARTRealtime.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
#import <Ably/ARTRealtimeChannels.h>
#import <Ably/ARTEventEmitter.h>
#import <Ably/ARTConnection.h>
#import <Ably/ARTRealtimeChannels.h>

@class ARTStatus;
@class ARTMessage;
Expand All @@ -20,7 +21,6 @@
@class ARTAuth;
@class ARTPush;
@class ARTProtocolMessage;
@class ARTRealtimeChannels;

NS_ASSUME_NONNULL_BEGIN

Expand All @@ -41,6 +41,11 @@
*/
@property (readonly, nullable) NSString *clientId;

/**
* An `ARTChannels` object. TODO docs
*/
@property (readonly) id<ARTRealtimeChannelsProtocol> channels;

Check failure on line 47 in Source/include/Ably/ARTRealtime.h

View workflow job for this annotation

GitHub Actions / check (tvOS, test_tvOS17_2) 

cannot find protocol declaration for 'ARTRealtimeChannelsProtocol'; did you mean 'ARTRealtimeChannelProtocol'?

Check failure on line 47 in Source/include/Ably/ARTRealtime.h

View workflow job for this annotation

GitHub Actions / check (tvOS, test_tvOS17_2) 

cannot find protocol declaration for 'ARTRealtimeChannelsProtocol'; did you mean 'ARTRealtimeChannelProtocol'?

Check failure on line 47 in Source/include/Ably/ARTRealtime.h

View workflow job for this annotation

GitHub Actions / check 

cannot find protocol declaration for 'ARTRealtimeChannelsProtocol'; did you mean 'ARTRealtimeChannelProtocol'?

Check failure on line 47 in Source/include/Ably/ARTRealtime.h

View workflow job for this annotation

GitHub Actions / check 

cannot find protocol declaration for 'ARTRealtimeChannelsProtocol'; did you mean 'ARTRealtimeChannelProtocol'?

Check failure on line 47 in Source/include/Ably/ARTRealtime.h

View workflow job for this annotation

GitHub Actions / check (macOS, test_macOS) 

cannot find protocol declaration for 'ARTRealtimeChannelsProtocol'; did you mean 'ARTRealtimeChannelProtocol'?

Check failure on line 47 in Source/include/Ably/ARTRealtime.h

View workflow job for this annotation

GitHub Actions / check (macOS, test_macOS) 

cannot find protocol declaration for 'ARTRealtimeChannelsProtocol'; did you mean 'ARTRealtimeChannelProtocol'?

Check failure on line 47 in Source/include/Ably/ARTRealtime.h

View workflow job for this annotation

GitHub Actions / check (iOS, test_iOS17_2) 

cannot find protocol declaration for 'ARTRealtimeChannelsProtocol'; did you mean 'ARTRealtimeChannelProtocol'?

Check failure on line 47 in Source/include/Ably/ARTRealtime.h

View workflow job for this annotation

GitHub Actions / check (iOS, test_iOS17_2) 

cannot find protocol declaration for 'ARTRealtimeChannelsProtocol'; did you mean 'ARTRealtimeChannelProtocol'?

/// :nodoc:
- (instancetype)init NS_UNAVAILABLE;

Expand Down Expand Up @@ -134,7 +139,7 @@
/**
* An `ARTChannels` object.
*/
@property (readonly) ARTRealtimeChannels *channels;

Check failure on line 142 in Source/include/Ably/ARTRealtime.h

View workflow job for this annotation

GitHub Actions / check (tvOS, test_tvOS17_2) 

unknown type name 'ARTRealtimeChannels'; did you mean 'ARTRealtimeChannel'?

Check failure on line 142 in Source/include/Ably/ARTRealtime.h

View workflow job for this annotation

GitHub Actions / check (tvOS, test_tvOS17_2) 

unknown type name 'ARTRealtimeChannels'; did you mean 'ARTRealtimeChannel'?

Check failure on line 142 in Source/include/Ably/ARTRealtime.h

View workflow job for this annotation

GitHub Actions / check 

unknown type name 'ARTRealtimeChannels'; did you mean 'ARTRealtimeChannel'?

Check failure on line 142 in Source/include/Ably/ARTRealtime.h

View workflow job for this annotation

GitHub Actions / check 

unknown type name 'ARTRealtimeChannels'; did you mean 'ARTRealtimeChannel'?

Check failure on line 142 in Source/include/Ably/ARTRealtime.h

View workflow job for this annotation

GitHub Actions / check (macOS, test_macOS) 

unknown type name 'ARTRealtimeChannels'; did you mean 'ARTRealtimeChannel'?

Check failure on line 142 in Source/include/Ably/ARTRealtime.h

View workflow job for this annotation

GitHub Actions / check (macOS, test_macOS) 

unknown type name 'ARTRealtimeChannels'; did you mean 'ARTRealtimeChannel'?

Check failure on line 142 in Source/include/Ably/ARTRealtime.h

View workflow job for this annotation

GitHub Actions / check (iOS, test_iOS17_2) 

unknown type name 'ARTRealtimeChannels'; did you mean 'ARTRealtimeChannel'?

Check failure on line 142 in Source/include/Ably/ARTRealtime.h

View workflow job for this annotation

GitHub Actions / check (iOS, test_iOS17_2) 

unknown type name 'ARTRealtimeChannels'; did you mean 'ARTRealtimeChannel'?
/**
* An `ARTPush` object.
*/
Expand Down
Loading