RTL6c: Publish while not connected #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base automatically changed from
feature/conn-open-failures-rtn14
to
integration/1.2
November 6, 2020 15:28
tcard
force-pushed
the
feature/rtl6c-queue-messages
branch
from
8dfe308 to
ac32479
Compare
Otherwise, further operations can fail, as they may find the connection still INITIALIZED.
Also, remove result argument. Now a result is always returned and can be safely ignored.
realtime_conn_spec_test.go:1868: expected i/o timeout to be 5ms got 5.553111ms
tcard
force-pushed
the
feature/rtl6c-queue-messages
branch
from
3505b84 to
45023f3
Compare
We were reattaching if the resumed CONNECTED message brought an error, but per RTN15c3, we only need to attach if we didn't resume and the error only affects the connection's error reason.
Previous way was flaky due to the artificially short timeouts:
--- FAIL: TestRealtimeConn_RTN23 (0.00s)
realtime_conn_spec_test.go:1764: [ErrorInfo :timeout code=80003 disconnected statusCode=0] See https://help.ably.io/error/80003
lmars
reviewed
Nov 9, 2020
2 tasks
lmars
approved these changes
Nov 9, 2020
gernest
approved these changes
Nov 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR also includes random fixes that came up during testing, including the culprit of #172's CI failure.