Migrate Presence.get and REST.request to new paginated results #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We started doing this and then stopped.
Jus extract the items for them, while checking that each page is as long as we expect it to be. This avoids the need for Equal, and will make it easy to sort the result client-side to get consistent results from paginated queries whose order is undefined.
We could reuse the existing PresenceHistoryRequest, which has been renamed to just PresenceRequest.
lmars
approved these changes
Apr 16, 2021
…e/presence-get-request
Calls to doWithHandle can be concurrent, so their write accesses to successFallbackHost were racy.
We were sharing the PresenceFixtures slice between goroutines, which is written at when unmarshaling POST /app.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This finishes implementing the paginated result design, which are the last major API fixes outstanding.