Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Read and persist state returned in LocalDevice/ DeviceDetails #697

Closed
ben-xD opened this issue Aug 6, 2021 · 2 comments
Closed

Read and persist state returned in LocalDevice/ DeviceDetails #697

ben-xD opened this issue Aug 6, 2021 · 2 comments
Assignees
@martin-morek
Labels
bug Something isn't working. It's clear that this does need to be fixed.

Comments

@ben-xD
Copy link
Contributor

ben-xD commented Aug 6, 2021 •
edited by sync-by-unito bot
Loading

In trying to make sure behaviour is correct in push notifications, I noticed that the DeviceDetails.Push.state is always null on Android and iOS. A user can get the LocalDevice by calling AblyRealtime#device, to get back LocalDevice, which extends from DeviceDetails, which contains DeviceDetails.Push. Unfortunately, DeviceDetails.Push.state is always nil.

It looks like it was never implemented? This value is not null when using the http api/ dashboard, its just the fact that ably-cocoa and ably-java doesn’t ever use it. This value is definitely returned to SDKs which call POST /push/deviceRegistrations. However, it is also returned by other HTTP requests, e.g. PUT rest.ably.io/push/deviceRegistrations/.

In ably-java, this is called in ActivationStateMachine.java, at WaitingForPushDeviceDetails#transition.

Similar ably-cocoa issue: ably/ably-cocoa#1162

┆Issue is synchronized with this Jira Bug by Unito
@ben-xD ben-xD added the bug Something isn't working. It's clear that this does need to be fixed. label Aug 6, 2021
@ben-xD ben-xD changed the title Read and persist state returned in ARTLocalDevice/ ARTDeviceDetails Read and persist state returned in LocalDevice/ DeviceDetails Aug 6, 2021
@ben-xD ben-xD mentioned this issue Aug 6, 2021
Closed
@ben-xD ben-xD changed the title Read and persist state returned in LocalDevice/ DeviceDetails Read and persist state returned in LocalDevice/ DeviceDetails Aug 6, 2021
@ben-xD ben-xD mentioned this issue Aug 6, 2021
Open
@ben-xD ben-xD changed the title Read and persist state returned in LocalDevice/ DeviceDetails Read and persist state returned in LocalDevice/ DeviceDetails Sep 7, 2021
@ben-xD
Copy link
Contributor Author

ben-xD commented Sep 7, 2021

Please take a look at discussions at ably/ably-cocoa#1162 before starting, it might need some API changes

This was referenced Oct 11, 2021
Closed
Closed
@ben-xD
Copy link
Contributor Author

ben-xD commented Nov 20, 2021

Closing this for now, and a new issue will be created once the feature spec is updated ably/specification#26

@ben-xD ben-xD closed this as completed Nov 20, 2021
@lawrence-forooghian lawrence-forooghian mentioned this issue Oct 3, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@martin-morek martin-morek

Labels
bug Something isn't working. It's clear that this does need to be fixed.
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ben-xD @martin-morek