Configurable internetUpUrl #1051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
temporarily deployed
to
staging/pull/1051/bundle-report
owenpearson
force-pushed
the
configure-internet-up-url
branch
from
dd312dc to
5cd5ad6
Compare
github-actions
bot
temporarily deployed
to
staging/pull/1051/bundle-report
owenpearson
force-pushed
the
configure-internet-up-url
branch
from
5cd5ad6 to
6e35ac2
Compare
github-actions
bot
temporarily deployed
to
staging/pull/1051/bundle-report
owenpearson
force-pushed
the
configure-internet-up-url
branch
from
6e35ac2 to
273086a
Compare
github-actions
bot
temporarily deployed
to
staging/pull/1051/bundle-report
owenpearson
force-pushed
the
configure-internet-up-url
branch
from
273086a to
6044f86
Compare
github-actions
bot
temporarily deployed
to
staging/pull/1051/bundle-report
owenpearson
force-pushed
the
configure-internet-up-url
branch
from
6044f86 to
eb714c0
Compare
github-actions
bot
temporarily deployed
to
staging/pull/1051/bundle-report
owenpearson
requested review from
paddybyers,
SimonWoolf,
QuintinWillison,
Peter-Maguire and
lmars
Peter-Maguire
approved these changes
Sep 15, 2022
lmars
reviewed
Sep 15, 2022
owenpearson
force-pushed
the
configure-internet-up-url
branch
from
eb714c0 to
51f0494
Compare
github-actions
bot
temporarily deployed
to
staging/pull/1051/bundle-report
owenpearson
force-pushed
the
configure-internet-up-url
branch
from
51f0494 to
b584135
Compare
github-actions
bot
temporarily deployed
to
staging/pull/1051/bundle-report
lmars
reviewed
Sep 21, 2022
mattheworiordan
approved these changes
Sep 22, 2022
owenpearson
force-pushed
the
configure-internet-up-url
branch
from
b584135 to
376362b
Compare
github-actions
bot
temporarily deployed
to
staging/pull/1051/bundle-report
owenpearson
force-pushed
the
configure-internet-up-url
branch
from
376362b to
a76d28e
Compare
github-actions
bot
temporarily deployed
to
staging/pull/1051/bundle-report
owenpearson
force-pushed
the
configure-internet-up-url
branch
from
a76d28e to
55c2633
Compare
github-actions
bot
temporarily deployed
to
staging/pull/1051/bundle-report
lmars
approved these changes
Oct 3, 2022
|
I've added @m-hulbert as a reviewer, given there is API commentary added. |
QuintinWillison
approved these changes
Oct 4, 2022
owenpearson
force-pushed
the
configure-internet-up-url
branch
from
55c2633 to
0bc0838
Compare
|
@QuintinWillison I've updated the API doc for that option, fixing the mistake you mentioned and also adding a better description. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation is based on the one described by Lewis here. The only difference is that this implementation allows any success status code.
Includes some very basic URL parsing so that provided
internetAvailabilityUrlcan optionally contain a url scheme and/or query params.