chat/add-delete-message-feature-spec #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
splindsay-92
force-pushed
the
chat/add-delete-message-feature-spec
branch
from
aa6d5b6 to
1559c88
Compare
splindsay-92
force-pushed
the
chat/add-delete-message-feature-spec
branch
from
1559c88 to
37b9a05
Compare
vladvelici
reviewed
Nov 11, 2024
AndyTWF
reviewed
Nov 12, 2024
|
@coderabbitai summary |
splindsay-92
force-pushed
the
chat/add-delete-message-feature-spec
branch
from
2c78a09 to
80391fa
Compare
AndyTWF
force-pushed
the
chat-lifecycle
branch
from
8ebed8d to
3b576d3
Compare
splindsay-92
force-pushed
the
chat/add-delete-message-feature-spec
branch
from
80391fa to
d99422d
Compare
splindsay-92
force-pushed
the
chat/add-delete-message-feature-spec
branch
from
b7a218a to
ded59cc
Compare
splindsay-92
force-pushed
the
chat/add-delete-message-feature-spec
branch
from
5b7a17b to
11c80cf
Compare
splindsay-92
force-pushed
the
chat/add-delete-message-feature-spec
branch
from
11c80cf to
b48cf89
Compare
splindsay-92
force-pushed
the
chat/add-delete-message-feature-spec
branch
from
b48cf89 to
a0e92d4
Compare
AndyTWF
reviewed
Nov 15, 2024
AndyTWF
reviewed
Nov 21, 2024
AndyTWF
approved these changes
Nov 21, 2024
splindsay-92
force-pushed
the
chat/add-delete-message-feature-spec
branch
from
95232a0 to
b2b6063
Compare
splindsay-92
force-pushed
the
chat/add-delete-message-feature-spec
branch
from
b2b6063 to
73c59b8
Compare
- Introduce V2 endpoints for sending, updating, and deleting messages, with corresponding changes in text structure and fields. - Deprecate existing V1 API elements.
Refine definitions of `serial` and `latestActionSerial` for message ordering to be lexicographically sortable.
- Also fixed div not correctly graying out the spec point CHA-M4c
Clarified the usage of "shall" and "must" to ensure consistency.
- Makes the spec more requirement focused.
This spec point is more of an informative blurb and the testable points are covered below.
splindsay-92
force-pushed
the
chat/add-delete-message-feature-spec
branch
from
73c59b8 to
43f928e
Compare
AndyTWF
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes updates to the chat features, including new changes to message ordering, the introduction of V2 API chat endpoints, and deprecation of old V1 endpoints and functionality.
Message Ordering and Serials:
@Serial@, a field on a chat message, containing a lexicographically sortable string. (textile/chat-features.textile).@timeserial@field for message ordering and replaced it with@serial@@latestActionSerial@for actions, a lexicographically sortable string similar to@serial@. (textile/chat-features.textile)API Endpoint Versioning:
textile/chat-features.textile).textile/chat-features.textile)Chat Message Updates:
@serial@,@latestActionSerial@,@action@etc..CSS and Styling Updates:
.deprecatedCSS class to apply a gray text color to deprecated elements (templates/main.css).