Update chat message materialisation fields #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladvelici
requested review from
a team,
owenpearson and
splindsay-92
and removed request for
a team
AndyTWF
reviewed
Jan 13, 2025
textile/chat-features.textile
Outdated
| ** @(CHA-M10b)@ This clause has been deleted. | ||
| ** @(CHA-M10c)@ This clause has been deleted. | ||
| ** @(CHA-M10d)@ This clause has been deleted. | ||
| ** @(CHA-M10e)@ @[Testable]@ To sort @Message@ @versions@ of the same @Message@ (instances with the same @serial@) in global order, sort @Message@ instances lexicographically by their @version@ property. Higher @version@ means newer. Lower means older. Equal means it is the same version. |
There was a problem hiding this comment.
I would split this into subpoints, e.g.
CHA-M10e1: Two messages are equal if...
e2: A message is newer than another if...
etc
vladvelici
force-pushed
the
chat-update-materialisation-fields
branch
from
d9ed087 to
c936afe
Compare
AndyTWF
approved these changes
Jan 13, 2025
textile/chat-features.textile
Outdated
| ** @(CHA-M10c)@ This clause has been deleted. | ||
| ** @(CHA-M10d)@ This clause has been deleted. | ||
| ** @(CHA-M10e)@ @[Testable]@ To sort @Message@ @versions@ of the same @Message@ (instances with the same @serial@) in global order, sort @Message@ instances lexicographically by their @version@ property. | ||
| ** @(CHA-M10e1)@ @[Testable]@ Two @Message@ instances of the same @serial@ are considered the same version if they have the same @version@ property. |
Co-authored-by: Steven <[email protected]>
vladvelici
force-pushed
the
chat-update-materialisation-fields
branch
from
c936afe to
5ecba46
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://ably.atlassian.net/browse/CHA-735
Addresses #254