Merge branch 'metri/testing' into metri/testing-unit-tests

aboutcircles · Jan 17, 2025 · 296652c · 296652c
2 parents ac0d576 + f2a5ee1
commit 296652c
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 21 deletions.
diff --git a/src/factory/CirclesBackingFactory.sol b/src/factory/CirclesBackingFactory.sol
@@ -30,19 +30,17 @@ contract CirclesBackingFactory {
     error UnsupportedBackingAsset(address requestedAsset);
     /// Deployment of CirclesBacking instance initiated by user `backer` has failed.
     error CirclesBackingDeploymentFailed(address backer);
-    /// Missing approval of this address to spend personal CRC.
-    error PersonalCirclesApprovalIsMissing();
-    /// Method can be called only by instance of CirclesBacking deployed by this factory.
+    /// Method can be called only by CirclesBacking instance deployed by this factory.
     error OnlyCirclesBacking();
     /// Unauthorized access.
     error NotAdmin();
     /// Exit Liquidity Bootstraping Pool supports only two tokens pools.
     error OnlyTwoTokenLBPSupported();
 
     // Events
-    /// @notice Emitted when a CirclesBacking is created.
+    /// @notice Emitted when a CirclesBacking instance is created.
     event CirclesBackingDeployed(address indexed backer, address indexed circlesBackingInstance);
-    /// @notice Emitted when a LBP is created.
+    /// @notice Emitted when a LBP instance is created.
     event LBPDeployed(address indexed circlesBackingInstance, address indexed lbp);
     /// @notice Emitted when a Circles backing process is initiated.
     event CirclesBackingInitiated(

diff --git a/src/interfaces/IVault.sol b/src/interfaces/IVault.sol
@@ -92,22 +92,6 @@ interface IVault {
         bool toInternalBalance;
     }
 
-    /**
-     * @dev Emitted when a user joins or exits a Pool by calling `joinPool` or `exitPool`, respectively.
-     */
-    event PoolBalanceChanged(
-        bytes32 indexed poolId,
-        address indexed liquidityProvider,
-        IERC20[] tokens,
-        int256[] deltas,
-        uint256[] protocolFeeAmounts
-    );
-
-    enum PoolBalanceChangeKind {
-        JOIN,
-        EXIT
-    }
-
     /**
      * @dev Returns a Pool's registered tokens, the total balance for each, and the latest block when *any* of
      * the tokens' `balances` changed.