-
-
Notifications
You must be signed in to change notification settings - Fork 563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update licenses from SPDX License List 3.26 and others #4081
base: develop
Are you sure you want to change the base?
Conversation
These license were added to dejacode by @DennisClark Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
Reference: #4045 Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
5321771
to
a525083
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AyanSinhaMahapatra Please see my comments on 4 licenses regarding the Owner names.
97e121b
to
475aeea
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some nits wrt. rules.
src/licensedcode/data/rules/lgpl-2.1_with_broadcom-linking-exception-2.0_1.RULE
Show resolved
Hide resolved
src/licensedcode/data/rules/independent-module-linking-exception_1.RULE
Outdated
Show resolved
Hide resolved
@AyanSinhaMahapatra i have completed my review of the new/updated licenses and owners in DejaCode, applying the standard data enrichments, and no corrections were necessary. |
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
475aeea
to
bb7ac7d
Compare
Thanks @pombredanne @DennisClark for your suggestions, I've incorporated them all. Ready for review again |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
These were added by @DennisClark Reference: #4080 Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
515385e
to
4a45d5b
Compare
Fixes #4045
Tasks
Run tests locally to check for errors.