Add support for Xcode 16 #440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Interestingly just trying to compile in CI on Xcode 16 fails for another reason that the Swift 6 stuff: https://github.com/aboutyou/dart_packages/actions/runs/10946498511/job/30393146217?pr=440 Will set this up locally now to get some more insight as to what's the issue there. Hopefully we can find a way without breaking older Xcode versions (else we'll need to make a major release, which would also be fine I suppose, as I don't foresee important feature updates here for people who can not update Xcode yet (as I would also not advice to with the first release…)). https://telemetrydeck.com/blog/migrating-to-swift-6/ might also contain some useful pointers. |
tp
force-pushed
the
xcode-16
branch
2 times, most recently
from
235f7e0 to
5f9836f
Compare
tp
force-pushed
the
xcode-16
branch
3 times, most recently
from
6c748fd to
413f9f5
Compare
tp
commented
Sep 26, 2024
packages/sign_in_with_apple/sign_in_with_apple/example/ios/Runner.xcodeproj/project.pbxproj
Show resolved
Hide resolved
tp
commented
Sep 26, 2024
packages/sign_in_with_apple/sign_in_with_apple/darwin/Classes/SignInWithAppleError.swift
Show resolved
Hide resolved
Fixes #437 Example: Automatic project migration when running with Xcode 16 Use iOS 12 as minimum deployment target Upgrade example app to Swift 6 language mode Add conditional compilation to support both Swift 5 and 6 language mode
HenriBeck
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #437