Fixed stdin to work for windows. Updated GO 1.20 #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abrander
requested changes
Jun 26, 2023
go.mod
Outdated
| @@ -1,8 +1,16 @@ | |||
| module github.com/abrander/garmin-connect | |||
| module github.com/garmin-connect | |||
There was a problem hiding this comment.
Ya that is weird i dont know why go did that when i refreshed the go.mod for 1.20
There was a problem hiding this comment.
Figured it out . It was due to my folder structure
|
|
||
| go 1.15 | ||
| go 1.20 |
There was a problem hiding this comment.
Is Go 1.20 needed for this fix?
There was a problem hiding this comment.
No i was just moving it to 1.20 as there are some tls security fixes so feel free to remove it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix password stdin to work on windows and upgraded golang to 1.20