Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSSDK-21 - Update Certs service to Typescript #26

Merged
merged 6 commits into from
Jun 13, 2024

Conversation

Musilah
Copy link
Contributor

@Musilah Musilah commented Apr 4, 2024

What does this do?

This updates the certs service to use typescript and adds Certs Tests

Which issue(s) does this PR fix/relate to?

Resolves #21
Resolves #22 for Certs tests

List any changes that modify/break current functionality

N/A

Have you included tests for your changes?

Yes

Did you document any new/modified functionality?

None

Notes

@Musilah Musilah marked this pull request as ready for review April 4, 2024 23:14
@Musilah Musilah force-pushed the certsTS branch 4 times, most recently from d742f9b to 7fbf1b4 Compare April 9, 2024 12:45
Musilah added 5 commits April 23, 2024 12:24
Signed-off-by: Musilah <[email protected]>
Signed-off-by: Musilah <[email protected]>
Signed-off-by: Musilah <[email protected]>
Signed-off-by: Musilah <[email protected]>
Copy link
Contributor

@ianmuchyri ianmuchyri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dborovcanin dborovcanin merged commit f3c0bcc into absmach:main Jun 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update JS SDK tests for users, domains, groups, invitations and certs Update JS SDK for certs
4 participants