MG-28 - Align Bootstrap with SuperMQ #31
Conversation
Signed-off-by: Felix Gateru <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #31 +/- ##
===========================================
+ Coverage 40.45% 51.81% +11.35%
===========================================
Files 69 39 -30
Lines 6451 4113 -2338
===========================================
- Hits 2610 2131 -479
+ Misses 3555 1731 -1824
+ Partials 286 251 -35 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Felix Gateru <[email protected]>
Signed-off-by: Felix Gateru <[email protected]>
felixgateru
force-pushed
the
mg28-bootstrap
branch
from
c1b5d1a to
a05e37c
Compare
Signed-off-by: Felix Gateru <[email protected]>
| // SDK contains SuperMQ API. | ||
| // | ||
| //go:generate mockery --name SDK --output=./mocks --filename sdk.go --quiet --note "Copyright (c) Abstract Machines" | ||
| type SDK interface { |
There was a problem hiding this comment.
MG SDK should include SMQ SDK so you can combine MG features and SMQ features using a single tool.
There was a problem hiding this comment.
I cannot complete this change before the methods are removed from the SDK interface in supermq
There was a problem hiding this comment.
You mean until they are removed from SMQ SDK due to name conflict?
Signed-off-by: Felix Gateru <[email protected]>
Signed-off-by: Felix Gateru <[email protected]>
Signed-off-by: Felix Gateru <[email protected]>
Signed-off-by: Felix Gateru <[email protected]>
There was a problem hiding this comment.
@felixgateru We also need MG CLI that uses both MG and SMQ SDKs.
What type of PR is this?
This is a refactor as it aligns bootstrap with the new architecture implemented in superMQ.
What does this do?
This pr modifies the following files:
bootstrap/middleware/authorization.go- updates authorizationcmd/bootstrap/main.go- adds channels and domains configurationdocker/docker-compose.yml- updates to deploymentand requisite changes for deployment
and adds the following:
pkg/sdk- adds bootstrap sdkWhich issue(s) does this PR fix/relate to?
Have you included tests for your changes?
No, code is covered by tests.
Did you document any new/modified feature?
No
Notes
None