Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PROP-31 - Automate propeller startup #47

Merged
merged 25 commits into from
Jan 17, 2025
Merged

Conversation

nyagamunene
Copy link
Contributor

@nyagamunene nyagamunene commented Jan 9, 2025

What type of PR is this?

This pull request introduces a comprehensive set of changes to the Propeller CLI and configuration management. The modifications include adding a new provisioning command, updating configuration handling across multiple components, introducing a new configuration loading mechanism, and enhancing CLI flexibility. The changes allow for more dynamic configuration through environment variables and a new config.toml file, with updates spanning the CLI, manager, proplet, and proxy components.

What does this do?

  • New Features

    • Added a new CLI command for resource provisioning.
    • Enhanced configuration management with support for loading settings from a TOML file.
    • Introduced more flexible command-line configuration options.
  • Improvements

    • Streamlined CLI command structure.
  • Dependencies

    • Updated Go version to 1.23.4.
    • Added new dependencies for enhanced CLI and configuration management.
  • Chores

    • Updated Docker image tag to version v0.15.1.

Which issue(s) does this PR fix/relate to?

Have you included tests for your changes?

Did you document any new/modified features?

Notes

sequenceDiagram
    participant CLI as CLI
    participant Provision as Provision Command
    participant SDK as SuperMQ SDK
    participant Config as Config File

    CLI->>Provision: Trigger provision command
    Provision->>Provision: Validate/Generate inputs
    Provision->>SDK: Create access token
    SDK-->>Provision: Token created
    Provision->>SDK: Create domain
    SDK-->>Provision: Domain created
    Provision->>SDK: Create resources
    SDK-->>Provision: Resources created
    Provision->>Config: Write config.toml
    Config-->>Provision: Configuration saved
Loading

provision/provision.sh Outdated Show resolved Hide resolved
Copy link
Member

@rodneyosodo rodneyosodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Split this PR into to supermq change and propeller setup

@nyagamunene nyagamunene self-assigned this Jan 13, 2025
@nyagamunene nyagamunene marked this pull request as ready for review January 13, 2025 14:07
provision/provision.sh Outdated Show resolved Hide resolved
Signed-off-by: nyagamunene <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
rodneyosodo and others added 2 commits January 17, 2025 12:12
Signed-off-by: Rodney Osodo <[email protected]>
Copy link
Contributor

@drasko drasko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drasko drasko merged commit 97b8ab2 into absmach:main Jan 17, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Develop the starting script
3 participants