NOISSUE - Add group API tests (#243)

Signed-off-by: rodneyosodo <[email protected]>

.github/workflows/check-generated-files.yml

@@ -51,6 +51,7 @@ jobs:
               - "auth/policies.go"
               - "pkg/events/events.go"
               - "provision/service.go"
+              - "pkg/groups/groups.go"
 
       - name: Set up protoc
         if: steps.changes.outputs.proto == 'true'
@@ -111,6 +112,8 @@ jobs:
           mv ./pkg/events/mocks/publisher.go ./pkg/events/mocks/publisher.go.tmp
           mv ./pkg/events/mocks/subscriber.go ./pkg/events/mocks/subscriber.go.tmp
           mv ./provision/mocks/service.go ./provision/mocks/service.go.tmp
+          mv ./pkg/groups/mocks/repository.go ./pkg/groups/mocks/repository.go.tmp
+          mv ./pkg/groups/mocks/service.go ./pkg/groups/mocks/service.go.tmp
 
           make mocks
 
@@ -140,3 +143,5 @@ jobs:
           check_mock_changes ./pkg/events/mocks/publisher.go "ES Publisher ./pkg/events/mocks/publisher.go"
           check_mock_changes ./pkg/events/mocks/subscriber.go "EE Subscriber ./pkg/events/mocks/subscriber.go"
           check_mock_changes ./provision/mocks/service.go "Provision Service ./provision/mocks/service.go"
+          check_mock_changes ./pkg/groups/mocks/repository.go "Groups Repository ./pkg/groups/mocks/repository.go"
+          check_mock_changes ./pkg/groups/mocks/service.go "Groups Service ./pkg/groups/mocks/service.go"

internal/groups/api/decode.go

@@ -17,11 +17,6 @@ import (
 	"github.com/go-chi/chi/v5"
 )
 
-const (
-	defRelation   = "viewer"
-	defPermission = "view"
-)
-
 func DecodeListGroupsRequest(_ context.Context, r *http.Request) (interface{}, error) {
 	pm, err := decodePageMeta(r)
 	if err != nil {
@@ -211,6 +206,9 @@ func DecodeChangeGroupStatus(_ context.Context, r *http.Request) (interface{}, e
 }
 
 func DecodeAssignMembersRequest(_ context.Context, r *http.Request) (interface{}, error) {
+	if !strings.Contains(r.Header.Get("Content-Type"), api.ContentType) {
+		return nil, errors.Wrap(apiutil.ErrValidation, apiutil.ErrUnsupportedContentType)
+	}
 	req := assignReq{
 		token:   apiutil.ExtractBearerToken(r),
 		groupID: chi.URLParam(r, "groupID"),
@@ -222,6 +220,9 @@ func DecodeAssignMembersRequest(_ context.Context, r *http.Request) (interface{}
 }
 
 func DecodeUnassignMembersRequest(_ context.Context, r *http.Request) (interface{}, error) {
+	if !strings.Contains(r.Header.Get("Content-Type"), api.ContentType) {
+		return nil, errors.Wrap(apiutil.ErrValidation, apiutil.ErrUnsupportedContentType)
+	}
 	req := unassignReq{
 		token:   apiutil.ExtractBearerToken(r),
 		groupID: chi.URLParam(r, "groupID"),
@@ -235,11 +236,11 @@ func DecodeUnassignMembersRequest(_ context.Context, r *http.Request) (interface
 func DecodeListMembersRequest(_ context.Context, r *http.Request) (interface{}, error) {
 	memberKind, err := apiutil.ReadStringQuery(r, api.MemberKindKey, "")
 	if err != nil {
-		return nil, apiutil.ErrInvalidQueryParams
+		return nil, errors.Wrap(apiutil.ErrValidation, err)
 	}
-	permission, err := apiutil.ReadStringQuery(r, api.PermissionKey, defPermission)
+	permission, err := apiutil.ReadStringQuery(r, api.PermissionKey, api.DefPermission)
 	if err != nil {
-		return nil, apiutil.ErrInvalidQueryParams
+		return nil, errors.Wrap(apiutil.ErrValidation, err)
 	}
 	req := listMembersReq{
 		token:      apiutil.ExtractBearerToken(r),