Skip to content

Commit

Permalink
NOISSUE - Uncomment Code (#1926)
Browse files Browse the repository at this point in the history
* Uncomment all code

Signed-off-by: Rodney Osodo <[email protected]>

* feat(linters): add godox and dupword linters

This commit adds two new linters, godox and dupword, to the linter configuration file (.golangci.yml). The godox linter checks for occurrences of TODO and FIXME comments in the codebase, helping to ensure that these comments are not forgotten or left unresolved. The dupword linter detects duplicate words in comments and strings, which can be a sign of typos or errors. These new linters will enhance the code quality and maintainability of the project.

Signed-off-by: Rodney Osodo <[email protected]>

* uncomment tests in /pkg/sdk/go/tokens_test.go

Signed-off-by: Rodney Osodo <[email protected]>

---------

Signed-off-by: Rodney Osodo <[email protected]>
  • Loading branch information
rodneyosodo authored Oct 18, 2023
1 parent 75b37e0 commit 5c270ab
Show file tree
Hide file tree
Showing 19 changed files with 9,381 additions and 10,397 deletions.
3 changes: 2 additions & 1 deletion .golangci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ linters:
- unused
- goconst
- godot
- godox
- ineffassign
- misspell
- stylecheck
Expand All @@ -68,5 +69,5 @@ linters:
- importas
- makezero
- mirror
- misspell
- nakedret
- dupword
4 changes: 1 addition & 3 deletions auth/api/http/keys/endpoint.go
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,7 @@ func issueEndpoint(svc auth.Service) endpoint.Endpoint {
res := issueKeyRes{
Value: tkn.AccessToken,
}
// if !key.ExpiresAt.IsZero() {
// res.ExpiresAt = &key.ExpiresAt
// }

return res, nil
}
}
Expand Down
Loading

0 comments on commit 5c270ab

Please sign in to comment.