Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NOISSUE - Modbus Adpater #1882

Closed
wants to merge 12 commits into from
Closed

NOISSUE - Modbus Adpater #1882

wants to merge 12 commits into from

Conversation

SammyOina
Copy link
Contributor

@SammyOina SammyOina commented Aug 8, 2023

What does this do?

Creates Modbus adapter on mainflux

Which issue(s) does this PR fix/relate to?

https://github.com/ultravioletrs/issues/issues/278

List any changes that modify/break current functionality

Have you included tests for your changes?

Did you document any new/modified functionality?

Notes

To test using a simulated device,

version: "2.1"
services:
  modbus:
    image: techplex/modbus-sim:latest
    container_name: modbus
    ports:
      - 1502:1502
    restart: unless-stopped

use the following to start reading:

mosquitto_pub -u aee63940-5c05-4c0c-afb8-2fb9cd304d9d -P b81b36b6-523e-4413-9405-d694e0feda4b -t channels/e90158ff-cc68-405a-9781-e145389f9448/messages/modbus/read/tcp/h_register -h localhost -m '{
        "config": {
                "address": "localhost:1502"
        },
        "options": {
                "address": 100,
                "quantity": 1
        }
}' -i desk

Get responses via:

coap-cli-linux get channels/e90158ff-cc68-405a-9781-e145389f9448/messages/modbus/res -auth b81b36b6-523e-4413-9405-d694e0feda4b -o

known issues: the message output is not clear output in terminal, maybe due to the message type on coap

@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Merging #1882 (9db71fe) into master (9dbe87f) will decrease coverage by 1.21%.
The diff coverage is 15.27%.

@@            Coverage Diff             @@
##           master    #1882      +/-   ##
==========================================
- Coverage   67.16%   65.95%   -1.21%     
==========================================
  Files         118      120       +2     
  Lines        9076     9292     +216     
==========================================
+ Hits         6096     6129      +33     
- Misses       2351     2528     +177     
- Partials      629      635       +6     
Files Changed Coverage Δ
modbus/adapter.go 0.00% <0.00%> (ø)
modbus/modbus.go 25.58% <25.58%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@SammyOina SammyOina changed the title create basic service NOISSUE - Modbus Adpater Aug 8, 2023
@SammyOina SammyOina force-pushed the modbus branch 2 times, most recently from 6da6766 to dee5c46 Compare August 11, 2023 08:01
Signed-off-by: SammyOina <[email protected]>
Signed-off-by: SammyOina <[email protected]>
Signed-off-by: SammyOina <[email protected]>
Signed-off-by: SammyOina <[email protected]>
Signed-off-by: SammyOina <[email protected]>
Signed-off-by: SammyOina <[email protected]>
update docs

Signed-off-by: SammyOina <[email protected]>
Signed-off-by: SammyOina <[email protected]>
Signed-off-by: SammyOina <[email protected]>
@SammyOina SammyOina marked this pull request as ready for review August 15, 2023 22:27
@SammyOina SammyOina requested a review from a team as a code owner August 15, 2023 22:27
@SammyOina SammyOina closed this Aug 17, 2023
@drasko
Copy link
Contributor

drasko commented Aug 17, 2023

PR moved here: mainflux/edge#1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants