Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MG-2051 - Fix unable to reset user password #2052

Closed
wants to merge 72 commits into from
Closed

MG-2051 - Fix unable to reset user password #2052

wants to merge 72 commits into from

Conversation

VeddySama
Copy link
Contributor

@VeddySama VeddySama commented Jan 10, 2024 •
edited by dborovcanin
Loading

What type of PR is this?

Fix Bug

What does this do?

Fixed unable to reset user password

Which issue(s) does this PR fix/relate to?

Have you included tests for your changes?

Did you document any new/modified feature?

Notes

@dborovcanin dborovcanin changed the title MG-2051 - Fixed unable to reset user password MG-2051 - Fix unable to reset user password Jan 10, 2024
dborovcanin
dborovcanin reviewed Jan 10, 2024
View reviewed changes
Copy link
Collaborator

@dborovcanin dborovcanin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, the changes look good. Can you add tests for this method?

@VeddySama
Copy link
Contributor Author

Thanks for the contribution, the changes look good. Can you add tests for this method?

I have completed the tests, please take a look

arvindh123
arvindh123 requested changes Jan 11, 2024
View reviewed changes
users/service_test.go Outdated Show resolved Hide resolved
@dborovcanin
Copy link
Collaborator

@ianmuchyri Please review. @VeddySama Can you, please, rebase?

@ianmuchyri
Copy link
Contributor

@ianmuchyri Please review. @VeddySama Can you, please, rebase?

@VeddySama please check lint error and sign off your commits. This is in line with the contribution guidelines.

rodneyosodo and others added 21 commits April 3, 2024 23:12
@rodneyosodo
NOISSUE - Add group service tests (#241)
ca49888 
Signed-off-by: Rodney Osodo <[email protected]>
@arvindh123
MG-1968 - List all status domains by default (#248)
73a2c07 
Signed-off-by: Arvindh <[email protected]>
@chaevan
NOISSUE - Increase minimum docker-compose version in README.md (#260)
97432fd
@Musilah
NOISSUE - Resolve falsely passing CI (#214)
4375254 
Signed-off-by: Musilah <[email protected]>
Co-authored-by: Musilah <[email protected]>
@arvindh123
MG-1961 - Add Domains OpenAPI Spec (#261)
7776e24 
Signed-off-by: Arvindh <[email protected]>
@arvindh123
MG-1967 - Handle errors in Things gRPC server and client (#257)
a10ab93 
Signed-off-by: Arvindh <[email protected]>
@arvindh123
NOISSUE - List Permissions when listing Users (#269)
32d43b1 
Signed-off-by: Arvindh <[email protected]>
@ianmuchyri
NOISSUE - Add pagemetadata to ReadMessage function in sdk (#2055)
d16e9ad 
Signed-off-by: ianmuchyri <[email protected]>
@arvindh123
NOISSUE - Fix Domain listing and updating (#271)
52b650f 
Signed-off-by: Arvindh <[email protected]>
@rodneyosodo
NOISSUE - Add group API tests (#243)
53d5e8b 
Signed-off-by: rodneyosodo <[email protected]>
@rodneyosodo
NOISSUE - Add tests for pkg/clients (#258)
8237312 
Signed-off-by: Rodney Osodo <[email protected]>
@rodneyosodo
NOISSUE - Fix Compose With v2.24.0 (#273)
da8ab37 
Signed-off-by: Rodney Osodo <[email protected]>
@rodneyosodo
NOISSUE - Use methods for accessing in generated code (#204)
b658847 
Signed-off-by: Rodney Osodo <[email protected]>
@Musilah @dborovcanin
MG-234 - Improve Logging (#255)
1b9d11a 
Signed-off-by: Musilah <[email protected]>
Signed-off-by: Musilah <[email protected]>
Co-authored-by: Musilah <[email protected]>
Co-authored-by: Dušan Borovčanin <[email protected]>
@felixgateru
NOISSUE - Improve tests in things service (#200)
08ab338 
Signed-off-by: felix.gateru <[email protected]>
@felixgateru
NOISSUE - Improve tests in users service (#194)
e89cd59 
Signed-off-by: felix.gateru <[email protected]>
@chaevan
NOISSUE - Limit Max Traces kept in-memory by Jaeger all-in-one (#259)
8631318 
Signed-off-by: Charlie Evans <[email protected]>
@rodneyosodo
NOISSUE - Bug Fix on Listing Things (#274)
eba62a8 
Signed-off-by: Rodney Osodo <[email protected]>
@dborovcanin
NOISSUE - Update VerneMQ build scripts (#2058)
e4bbdf6 
Signed-off-by: Dusan Borovcanin <[email protected]>
@dborovcanin
NOISSUE - Update dependencies (#2061)
cd27330 
Signed-off-by: Dusan Borovcanin <[email protected]>
@dborovcanin
NOISSUE - Revert Mosquitto broker version in MQTT tests (#2063)
5eb9592 
Signed-off-by: Dusan Borovcanin <[email protected]>
arvindh123 and others added 26 commits April 3, 2024 23:13
@arvindh123
NOISSUE - Fix panic during revocation of expired certificate (#2101)
17a9d36 
Signed-off-by: Arvindh <[email protected]>
@rodneyosodo
NOISSUE - Add job for checking go.mod changes (#2097)
233ecfa 
Signed-off-by: Rodney Osodo <[email protected]>
@arvindh123
NOISSUE - Fix assign and unassign commands in CLI (#2102)
e36919b 
Signed-off-by: Arvindh <[email protected]>
@rodneyosodo
NOISSUE - Add Event Subscriber Config (#2054)
5d54aa8 
Signed-off-by: Rodney Osodo <[email protected]>
@rodneyosodo
MG-1887 - Add support for OAuth2.0 (#2103)
f116e28 
Signed-off-by: Rodney Osodo <[email protected]>
@ianmuchyri
NOISSUE - Update UI service env variables (#2105)
292c08b 
Signed-off-by: ianmuchyri <[email protected]>
@Musilah @rodneyosodo
NOISSUE - Update timescale reader (#2085)
145fdb3 
Signed-off-by: Musilah <[email protected]>
Signed-off-by: Rodney Osodo <[email protected]>
Co-authored-by: Rodney Osodo <[email protected]>
@ianmuchyri
NOISSUE - Update UI environment variables (#2107)
49d25af 
Signed-off-by: ianmuchyri <[email protected]>
@dependabot
NOISSUE - Bump github.com/go-jose/go-jose/v3 from 3.0.1 to 3.0.3 (#2108)
2200a2d 
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@ianmuchyri
NOISSUE - Update Aggregation SQL query (#2111)
6929ea4 
Signed-off-by: ianmuchyri <[email protected]>
@dependabot
NOISSUE - Bump github.com/lestrrat-go/jwx/v2 from 2.0.19 to 2.0.21 (#…
110ac4b 
…2110)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@rodneyosodo
NOISSUE - Add Secret Validation on Registration (#2109)
b6a1cb8 
Signed-off-by: Rodney Osodo <[email protected]>
@dependabot
NOISSUE - Bump google.golang.org/protobuf from 1.32.0 to 1.33.0 (#2112)
291c2a3 
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@rodneyosodo
NOISSUE - Remove OAuth2.0 tokens from Magistrala token (#2106)
7ee657c 
Signed-off-by: Rodney Osodo <[email protected]>
Signed-off-by: rodneyosodo <[email protected]>
@dependabot
NOISSUE - Bump github.com/jackc/pgx/v5 from 5.5.2 to 5.5.4 (#2116)
6e6dfba 
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@rodneyosodo
NOISSUE - Convert SenML Payload Time To UnixNano (#2115)
887072f 
Signed-off-by: Rodney Osodo <[email protected]>
Signed-off-by: rodneyosodo <[email protected]>
@arvindh123
NOISSUE - Add Domain URL to CLI and SDK configuration (#2118)
441d3a7 
Signed-off-by: Arvindh <[email protected]>
@rodneyosodo
NOISSUE - Add property based testing to users service (#2087)
f5d0c41 
Signed-off-by: Rodney Osodo <[email protected]>
@dependabot
NOISSUE - Bump github.com/docker/docker from 24.0.7+incompatible to 2…
698d213 
…4.0.9+incompatible (#2123)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@ianmuchyri
NOISSUE - Fix Timescale Reader query (#2120)
0f4a709 
Signed-off-by: ianmuchyri <[email protected]>
@WashingtonKK
NOISSUE - Fix OPC-UA adapter (#2114)
097b547 
Signed-off-by: WashingtonKK <[email protected]>
@dborovcanin
NOISSUE - Fix links in README.md file (#2129)
a5c7d8e 
Signed-off-by: Dusan Borovcanin <[email protected]>
@rodneyosodo
NOISSUE - Fix Failing Users Property Based Tests (#2134)
4c4217d 
Signed-off-by: Rodney Osodo <[email protected]>
@JeffMboya
MG-2125 - Unable to enable thing using bootstrap (#2132)
9ffbc5e 
Signed-off-by: JeffMboya <[email protected]>
Reset secret tests
834dd56
@VeddySama
Merge branch 'main' into MG-2051
3fec0a5
@VeddySama
Copy link
Contributor Author

@ianmuchyri请查阅。@VeddySama你能重新建立基础吗？

Should I do it like I am doing now or should I re-establish a branch?

@VeddySama
Copy link
Contributor Author

VeddySama commented Apr 3, 2024 •
edited
Loading

I saw that the latest PR has been modified to submit this issue. You can adopt this PR.
https://github.com/absmach/magistrala/pull/2135

@VeddySama VeddySama closed this Apr 3, 2024
@dborovcanin
Copy link
Collaborator

@VeddySama Thanks for the contribution and sorry for the confusion; @ianmuchyri accidentally sent a PR without checking if there is a pending one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arvindh123 arvindh123 arvindh123 requested changes

@dborovcanin dborovcanin dborovcanin left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Unable to reset user password