NOISSUE - Add Event Subscriber Config #2054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodneyosodo
force-pushed
the
events-refactor
branch
7 times, most recently
from
f7e045d to
ec560a0
Compare
rodneyosodo
force-pushed
the
events-refactor
branch
3 times, most recently
from
2bb4b1a to
a33e439
Compare
dborovcanin
force-pushed
the
events-refactor
branch
from
a33e439 to
51b7060
Compare
rodneyosodo
force-pushed
the
events-refactor
branch
2 times, most recently
from
299e53b to
f81067c
Compare
rodneyosodo
force-pushed
the
events-refactor
branch
from
f81067c to
876680a
Compare
dborovcanin
force-pushed
the
events-refactor
branch
from
876680a to
310d009
Compare
rodneyosodo
force-pushed
the
events-refactor
branch
3 times, most recently
from
c5b65ee to
3bed0ba
Compare
This commit adds event subscriber which combines stream, consumer and handler to a single struct to the codebase. The code is related to event handling, subscribing to event stores, and using message brokers like RabbitMQ, Redis, and NATS. Signed-off-by: Rodney Osodo <[email protected]>
The code changes involve updating the "thingsStream" variable and modifying configurations and log messages in multiple files across different directories and packages. The changes include adding "events." to the stream name, updating topic names, and modifying log messages for handling NATS and RabbitMQ events. Signed-off-by: Rodney Osodo <[email protected]>
Signed-off-by: Rodney Osodo <[email protected]>
dborovcanin
force-pushed
the
events-refactor
branch
from
3bed0ba to
fa6da0a
Compare
dborovcanin
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
This is a refactor PR as it add event subscriber option when consuming messages
What does this do?
This PR adds an event subscriber which combines stream, consumer and handler to a single struct to the codebase. The code is related to event handling, subscribing to event stores, and using message brokers like RabbitMQ, Redis, and NATS. Instead of passing consumer and stream at initializing the subscriber, we pass then when subscribing to the event
Which issue(s) does this PR fix/relate to?
Have you included tests for your changes?
Yes, I have included tests for my changes.
Did you document any new/modified feature?
Added godocs
Notes