-
Notifications
You must be signed in to change notification settings - Fork 672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NOISSUE - Update timescale reader #2085
Conversation
e8b0dc9
to
e531abe
Compare
The total count is not correct |
d7c6a91
to
44a30ec
Compare
44a30ec
to
acd3037
Compare
634c58e
to
bc94de8
Compare
f7d9899
to
25c3cf7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The epoch time attached to an aggregation query such as MAX and MIN for a value is not the time in which the MAX or MIN value occured.
Which is different from when the value occured:
It makes sense for aggregation to do this but there is a concern that the reason you are doing aggregation is to not only get the value but also the exact time within your desired interval in which the max occured.
787822b
to
50c288d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also update api documentation to include the 2 filters
86fc9b9
to
d984262
Compare
Signed-off-by: Musilah <[email protected]>
Signed-off-by: Musilah <[email protected]>
Signed-off-by: Musilah <[email protected]>
Signed-off-by: Musilah <[email protected]>
Signed-off-by: Musilah <[email protected]>
Signed-off-by: Musilah <[email protected]>
Signed-off-by: Musilah <[email protected]>
Signed-off-by: Musilah <[email protected]>
Signed-off-by: Musilah <[email protected]>
Signed-off-by: Musilah <[email protected]>
Signed-off-by: Musilah <[email protected]>
Signed-off-by: Musilah <[email protected]>
Signed-off-by: Musilah <[email protected]>
Signed-off-by: Musilah <[email protected]>
Signed-off-by: Musilah <[email protected]>
Signed-off-by: Musilah <[email protected]>
Signed-off-by: Musilah <[email protected]>
Signed-off-by: Musilah <[email protected]>
Signed-off-by: Musilah <[email protected]>
Signed-off-by: Musilah <[email protected]>
735dbd9
to
1fad094
Compare
Signed-off-by: Musilah <[email protected]>
- Add examples for aggregation, intervale, to and from parameters for the api docs - refactor transport validation when we have aggregation i.e KISS - simplify and rename SQL query Signed-off-by: Rodney Osodo <[email protected]>
Signed-off-by: Rodney Osodo <[email protected]>
What type of PR is this?
This a feature because it updates the Timescale reader.
What does this do?
This PR updates the Timescale Reader to be able to use aggregation queries for timeseries data to be used in dashboards charts.
Which issue(s) does this PR fix/relate to?
NOISSUE on Magistrala
Have you included tests for your changes?
No
Did you document any new/modified feature?
No
Notes