Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MG-2025 - CLI : Flag to print only curl output #2242

Merged
merged 19 commits into from
Jun 18, 2024

Conversation

JeffMboya
Copy link
Contributor

What type of PR is this?

This is a feature because it adds the ability to print only curl output in the CLI.

What does this do?

This PR adds a new flag --curl to the CLI. When this flag is used, the CLI will print the actual request sent as a cURL command. This will be useful for debugging and for users to visualize the request sent by the CLI/SDK.

The implementation uses the http2curl library to convert http requests to cURL commands.

Which issue(s) does this PR fix/relate to?

Have you included tests for your changes?

No.

Did you document any new/modified feature?

No

Makefile Outdated Show resolved Hide resolved
@JeffMboya JeffMboya force-pushed the MG-2025 branch 2 times, most recently from 92d735f to 9a205ec Compare June 12, 2024 08:18
@arvindh123 arvindh123 requested a review from dborovcanin June 12, 2024 10:24
@arvindh123
Copy link
Contributor

If this PR is Approved and ready for merge, then we need to create Ticket in Magistrala docs to update CLI docs https://github.com/absmach/magistrala-docs/issues/new

@JeffMboya
Copy link
Contributor Author

JeffMboya commented Jun 12, 2024

If this PR is Approved and ready for merge, then we need to create Ticket in Magistrala docs to update CLI docs https://github.com/absmach/magistrala-docs/issues/new

@arvindh123 https://github.com/absmach/magistrala-docs/issues/192

@dborovcanin dborovcanin merged commit 95badee into absmach:main Jun 18, 2024
4 checks passed
JeffMboya added a commit to JeffMboya/supermq that referenced this pull request Jun 20, 2024
JeffMboya added a commit to JeffMboya/supermq that referenced this pull request Jun 20, 2024
andychao217 pushed a commit to andychao217/magistrala that referenced this pull request Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CLI : Flag to print only curl output
3 participants