-
Notifications
You must be signed in to change notification settings - Fork 672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MG-2025 - CLI : Flag to print only curl output #2242
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arvindh123
requested changes
Jun 10, 2024
JeffMboya
force-pushed
the
MG-2025
branch
2 times, most recently
from
June 12, 2024 08:18
92d735f
to
9a205ec
Compare
If this PR is Approved and ready for merge, then we need to create Ticket in Magistrala docs to update CLI docs https://github.com/absmach/magistrala-docs/issues/new |
@arvindh123 https://github.com/absmach/magistrala-docs/issues/192 |
arvindh123
approved these changes
Jun 13, 2024
dborovcanin
approved these changes
Jun 18, 2024
Signed-off-by: JeffMboya <[email protected]>
Signed-off-by: JeffMboya <[email protected]>
Signed-off-by: JeffMboya <[email protected]>
Signed-off-by: JeffMboya <[email protected]>
Signed-off-by: JeffMboya <[email protected]>
Signed-off-by: JeffMboya <[email protected]>
Signed-off-by: JeffMboya <[email protected]>
Signed-off-by: JeffMboya <[email protected]>
Signed-off-by: JeffMboya <[email protected]>
Signed-off-by: JeffMboya <[email protected]>
Signed-off-by: JeffMboya <[email protected]>
Signed-off-by: JeffMboya <[email protected]>
Signed-off-by: JeffMboya <[email protected]>
Signed-off-by: JeffMboya <[email protected]>
Signed-off-by: JeffMboya <[email protected]>
Signed-off-by: JeffMboya <[email protected]>
Signed-off-by: JeffMboya <[email protected]>
Signed-off-by: JeffMboya <[email protected]>
Signed-off-by: JeffMboya <[email protected]>
JeffMboya
added a commit
to JeffMboya/supermq
that referenced
this pull request
Jun 20, 2024
Signed-off-by: JeffMboya <[email protected]>
JeffMboya
added a commit
to JeffMboya/supermq
that referenced
this pull request
Jun 20, 2024
Signed-off-by: JeffMboya <[email protected]>
andychao217
pushed a commit
to andychao217/magistrala
that referenced
this pull request
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
This is a feature because it adds the ability to print only curl output in the CLI.
What does this do?
This PR adds a new flag
--curl
to the CLI. When this flag is used, the CLI will print the actual request sent as a cURL command. This will be useful for debugging and for users to visualize the request sent by the CLI/SDK.The implementation uses the
http2curl
library to convert http requests to cURL commands.Which issue(s) does this PR fix/relate to?
Have you included tests for your changes?
No.
Did you document any new/modified feature?
No