Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MG-2048 - Implement Personal Access Tokens (PATs) #2492

Merged
merged 36 commits into from
Dec 18, 2024
Merged

MG-2048 - Implement Personal Access Tokens (PATs) #2492

merged 36 commits into from
Dec 18, 2024

Conversation

nyagamunene
Copy link
Contributor

@nyagamunene nyagamunene commented Oct 28, 2024 •
edited by dborovcanin
Loading

What type of PR is this?

This is a feature because it adds the following functionality: It add personal access token.

What does this do?

It adds personal access token.

Which issue(s) does this PR fix/relate to?

Have you included tests for your changes?

Yes

Did you document any new/modified feature?

No

Notes

@nyagamunene nyagamunene self-assigned this Oct 28, 2024
@dborovcanin dborovcanin mentioned this pull request Oct 28, 2024
Closed
@dborovcanin dborovcanin changed the title MG-2048 - Personal Access Tokens MG-2048 - implement Personal Access Tokens (PATs) Oct 28, 2024
@nyagamunene nyagamunene force-pushed the MG-2048 branch 5 times, most recently from c057ea7 to 3ad5253 Compare October 31, 2024 09:09
@nyagamunene nyagamunene changed the base branch from main to auth-refactor November 7, 2024 09:50
@nyagamunene nyagamunene force-pushed the MG-2048 branch 3 times, most recently from 2b465a8 to 7eee43e Compare November 7, 2024 11:17
@nyagamunene nyagamunene marked this pull request as ready for review November 10, 2024 20:11
arvindh123
arvindh123 requested changes Nov 12, 2024
View reviewed changes
auth/api/grpc/auth/client.go Show resolved Hide resolved
auth/api/grpc/auth/requests.go Outdated Show resolved Hide resolved
pkg/authn/authsvc/authn.go Outdated Show resolved Hide resolved
@arvindh123 arvindh123 force-pushed the auth-refactor branch 2 times, most recently from 3f43476 to 4323d34 Compare November 12, 2024 18:21
@dborovcanin dborovcanin force-pushed the auth-refactor branch 2 times, most recently from 33a88f8 to c1faa58 Compare November 26, 2024 11:41
@dborovcanin dborovcanin changed the title MG-2048 - implement Personal Access Tokens (PATs) MG-2048 - Implement Personal Access Tokens (PATs) Nov 26, 2024
@nyagamunene nyagamunene force-pushed the MG-2048 branch 2 times, most recently from b850dcb to 0ef2fa8 Compare November 27, 2024 13:07
@dborovcanin dborovcanin force-pushed the auth-refactor branch 2 times, most recently from 9d4dce1 to 4daa02b Compare December 2, 2024 10:27
@nyagamunene nyagamunene changed the base branch from auth-refactor to main December 2, 2024 14:16
@nyagamunene @dborovcanin
Increase scope coverage
f454af8 
Signed-off-by: nyagamunene <[email protected]>
@nyagamunene @dborovcanin
fix failing linter
85e53f0 
Signed-off-by: nyagamunene <[email protected]>
@nyagamunene @dborovcanin
Update protoc version
f784959 
Signed-off-by: nyagamunene <[email protected]>
@nyagamunene @dborovcanin
Add authenticate PAT grpc endpoint
58ea4ed 
Signed-off-by: nyagamunene <[email protected]>
@nyagamunene @dborovcanin
Revert Authenticate method
7622361 
Signed-off-by: nyagamunene <[email protected]>
@nyagamunene @dborovcanin
Update middleware, service and api
243d6a0 
Signed-off-by: nyagamunene <[email protected]>
@nyagamunene @dborovcanin
Add grpc authorizePAT
aaf497a 
Signed-off-by: nyagamunene <[email protected]>
@nyagamunene @dborovcanin
fix failing linter
15b44b6 
Signed-off-by: nyagamunene <[email protected]>
@nyagamunene @dborovcanin
fix protoc linter
0aa986e 
Signed-off-by: nyagamunene <[email protected]>
@nyagamunene @dborovcanin
fix indentation
c40560f 
Signed-off-by: nyagamunene <[email protected]>
@nyagamunene @dborovcanin
remove unused code
2e11e73 
Signed-off-by: nyagamunene <[email protected]>
@nyagamunene @dborovcanin
fix proto buffer files
75ab6e7 
Signed-off-by: nyagamunene <[email protected]>
@nyagamunene @dborovcanin
fix imports
0541a45 
Signed-off-by: nyagamunene <[email protected]>
@nyagamunene @dborovcanin
update protoc files
4d0733a 
Signed-off-by: nyagamunene <[email protected]>
@nyagamunene @dborovcanin
fix auth test
1e7a6fb 
Signed-off-by: nyagamunene <[email protected]>
@nyagamunene @dborovcanin
fix environment variables
3db9d2f 
Signed-off-by: nyagamunene <[email protected]>
@nyagamunene @dborovcanin
fix nginx
b57bca9 
Signed-off-by: nyagamunene <[email protected]>
@nyagamunene @dborovcanin
add check for token type
4811132 
Signed-off-by: nyagamunene <[email protected]>
@nyagamunene @dborovcanin
fix failing linter
691bc44 
Signed-off-by: nyagamunene <[email protected]>
@nyagamunene @dborovcanin
refactor keys endpoints
687023f 
Signed-off-by: nyagamunene <[email protected]>
@nyagamunene @dborovcanin
change api method from put to patch
b2ed92b 
Signed-off-by: nyagamunene <[email protected]>
@nyagamunene @dborovcanin
rename thing to client in scope
21c6f99 
Signed-off-by: nyagamunene <[email protected]>
@nyagamunene @dborovcanin
address comments
9c90047 
Signed-off-by: nyagamunene <[email protected]>
@nyagamunene @dborovcanin
remove pat check in keys api
fad8f86 
Signed-off-by: nyagamunene <[email protected]>
@nyagamunene @dborovcanin
add pat expiry check
5a27c8e 
Signed-off-by: nyagamunene <[email protected]>
@nyagamunene @dborovcanin
revert pat changes and update mocks
d983b3e 
Signed-off-by: nyagamunene <[email protected]>
@nyagamunene @dborovcanin
address comments
eb216d3 
Signed-off-by: nyagamunene <[email protected]>
dborovcanin
dborovcanin approved these changes Dec 18, 2024
View reviewed changes
Copy link
Collaborator

@dborovcanin dborovcanin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a lot of work that needs to be done, but let's merge the initial implementation and move on. I will open tickets for those tasks today.

@dborovcanin dborovcanin merged commit e8e17f5 into absmach:main Dec 18, 2024
6 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arvindh123 arvindh123 arvindh123 approved these changes

@dborovcanin dborovcanin dborovcanin approved these changes

@felixgateru felixgateru felixgateru left review comments

Assignees

@nyagamunene nyagamunene

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement Personal Access Tokens (PATs)
4 participants
@nyagamunene @dborovcanin @arvindh123 @felixgateru