Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NOISSUE - Move API to the common package #2608

Merged
merged 8 commits into from
Dec 19, 2024

Conversation

dborovcanin
Copy link
Collaborator

@dborovcanin dborovcanin commented Dec 19, 2024

What type of PR is this?

This is a code refactoring that changes package paths.

What does this do?

This pull request moves all the API common things to the api package, and moves API docs to apidocs.

Which issue(s) does this PR fix/relate to?

There is no such issue.
It is related to #2593.

Have you included tests for your changes?

No.

Did you document any new/modified feature?

N/A

Notes

N/A

@dborovcanin dborovcanin changed the title NOISSUE - Fix login NOISSUE - Move API to the common package Dec 19, 2024
Signed-off-by: Dusan Borovcanin <[email protected]>
Signed-off-by: Dusan Borovcanin <[email protected]>
Signed-off-by: Dusan Borovcanin <[email protected]>
Signed-off-by: Dusan Borovcanin <[email protected]>
Signed-off-by: Dusan Borovcanin <[email protected]>
Signed-off-by: Dusan Borovcanin <[email protected]>
SammyOina
SammyOina previously approved these changes Dec 19, 2024
Signed-off-by: Dusan Borovcanin <[email protected]>
Copy link

codecov bot commented Dec 19, 2024

Codecov Report

Attention: Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.

Project coverage is 40.43%. Comparing base (9e6da19) to head (ed79236).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
cli/provision.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2608      +/-   ##
==========================================
- Coverage   41.74%   40.43%   -1.31%     
==========================================
  Files         398      341      -57     
  Lines       51479    45419    -6060     
==========================================
- Hits        21489    18366    -3123     
+ Misses      27820    25678    -2142     
+ Partials     2170     1375     -795     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dborovcanin dborovcanin merged commit f0d014e into absmach:main Dec 19, 2024
6 of 9 checks passed
@dborovcanin dborovcanin deleted the fix-login branch December 19, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants