NOISSUE - Revert removal of notifier interface #2643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dborovcanin
approved these changes
Jan 13, 2025
dborovcanin
force-pushed
the
noissue-notifiers
branch
from
abbc9d1 to
2acf5f9
Compare
dborovcanin
requested changes
Jan 13, 2025
consumers/notifiers/notifier.go
Outdated
Comment on lines
18
to
22
| type Notifier interface { | ||
| // Notify method is used to send notification for the | ||
| // received message to the provided list of receivers. | ||
| Notify(from string, to []string, msg *messaging.Message) error | ||
| } |
There was a problem hiding this comment.
Move this file to the consumers root: consumers/notifier.go.
felixgateru
force-pushed
the
noissue-notifiers
branch
from
2acf5f9 to
a7be9d4
Compare
Signed-off-by: Felix Gateru <[email protected]>
Signed-off-by: Felix Gateru <[email protected]>
Signed-off-by: Felix Gateru <[email protected]>
dborovcanin
force-pushed
the
noissue-notifiers
branch
from
a7be9d4 to
8732d59
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
This is a refactor as it reverts the removal of the notifier interface.
What does this do?
This pr readds the
Notifierinterface atconsumers/notifiersas well as the mock file.Which issue(s) does this PR fix/relate to?
Related to pr#absmach/magistrala#33
Have you included tests for your changes?
No,
Did you document any new/modified feature?
In code documentation
Notes