Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two small fixes #16

Open
wants to merge 2 commits into
base: production
Choose a base branch
from

Conversation

buzzdeee
Copy link

with puppet 3.8.4, future parser, it fails to generate a catalog, because of illegal comma separated list in install.pp as well as in nagios_resources.pp

further, when it parsers the template for the web interface database setup, it's spitting out some warnings to prefix variables with @

Warning: Variable access via 'web_db_port' is deprecated. Use '@web_db_port' instead. template[/etc/puppet/environments/production/modules/icinga/templates/etc/icinga-web/conf.d/databases.xml.erb]:19
   (at /usr/local/lib/ruby/site_ruby/2.2/puppet/parser/templatewrapper.rb:77:in `method_missing')

Warning: Variable access via 'ido_db_port' is deprecated. Use '@ido_db_port' instead. template[/etc/puppet/environments/production/modules/icinga/templates/etc/icinga-web/conf.d/databases.xml.erb]:46
   (at /usr/local/lib/ruby/site_ruby/2.2/puppet/parser/templatewrapper.rb:77:in `method_missing')
@rendhalver
Copy link
Member

I have this fixed in the production branch now.
I have also put in some basic spec tests so this sort of thing will get detected earlier.
Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants