Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recoil - Code cleanup #10150

Merged
merged 3 commits into from
Jul 27, 2024
Merged

Recoil - Code cleanup #10150

merged 3 commits into from
Jul 27, 2024

Conversation

johnb432
Copy link
Contributor

When merged this pull request will:

  • Use hashmap for caching recoil values.
  • Minor code cleanup.

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@johnb432 johnb432 added the kind/cleanup Release Notes: **CHANGED:** label Jul 26, 2024
@johnb432 johnb432 added this to the 3.18.0 milestone Jul 26, 2024
@PabstMirror
Copy link
Contributor

We did the quote wrapping for hemtt, but it can now handle the math at compile time and store as number
Really doesn't matter but might be a tiny bit faster

@johnb432 johnb432 merged commit 8eefffe into master Jul 27, 2024
5 checks passed
@johnb432 johnb432 deleted the recoil-refactor branch July 27, 2024 12:43
blake8090 pushed a commit to blake8090/ACE3 that referenced this pull request Aug 18, 2024
* Recoil code cleanup

* Store recoil values as numbers in config, only `compile` if needed

* Updated header

---------

Co-authored-by: PabstMirror <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Release Notes: **CHANGED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants