Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Medical Treatment - Allow creating litter from classes #10649

Merged
merged 1 commit into from
Jan 13, 2025
Merged

Medical Treatment - Allow creating litter from classes #10649

merged 1 commit into from
Jan 13, 2025

Conversation

DartRuffian
Copy link
Contributor

When merged this pull request will:

  • Add a config property to litter items to create the simple object as the class instead of model path

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@PabstMirror
Copy link
Contributor

https://community.bistudio.com/wiki/createSimpleObject

the different syntaxes take a different position format (center vs bottom)
not sure if we'll have to adjust it, but nothing uses it by default so it's something we can see if it's an issue

@LinkIsGrim LinkIsGrim added this to the 3.18.2 milestone Jan 13, 2025
@LinkIsGrim
Copy link
Contributor

Fuck it we ball

@LinkIsGrim LinkIsGrim added the kind/enhancement Release Notes: **IMPROVED:** label Jan 13, 2025
@LinkIsGrim LinkIsGrim changed the title Medical Treatment - Add option for creating class simple objects Medical Treatment - Allow creating litter from classes Jan 13, 2025
@LinkIsGrim LinkIsGrim merged commit 6e6ad93 into acemod:master Jan 13, 2025
3 checks passed
@DartRuffian DartRuffian deleted the medical-treatment/customize-litter branch January 13, 2025 21:20
PlayerBotPro pushed a commit to PlayerBotPro/ACE3 that referenced this pull request Jan 14, 2025
@DartRuffian @PlayerBotPro
Medical Treatment - Allow creating litter from classes (acemod#10649)
05597a6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LinkIsGrim LinkIsGrim LinkIsGrim approved these changes

Assignees
No one assigned
Labels
kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Milestone
3.19.0
Development

Successfully merging this pull request may close these issues.
3 participants
@DartRuffian @PabstMirror @LinkIsGrim