-
Notifications
You must be signed in to change notification settings - Fork 740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Casings - Add support for dropped magazines (40mm shell casings) #9839
Open
PabstMirror
wants to merge
8
commits into
master
Choose a base branch
from
40mmBrass
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 6 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
f776c1b
Casings - Add support for dropped magazines (40mm shells)
PabstMirror 4b30e09
Merge branch 'master' into 40mmBrass
PabstMirror 3f9da5f
Add `ace_common_fnc_addPlayerEH`
PabstMirror a735ec5
Merge branch 'master' into 40mmBrass
PabstMirror 6c98b98
fix merge
PabstMirror 1159637
Merge branch 'master' into 40mmBrass
PabstMirror 4f9eb50
Merge branch 'master' into 40mmBrass
PabstMirror 1ba4b9c
update to use `CBA_fnc_addBISPlayerEventHandler`
PabstMirror File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,2 @@ | ||
PREP(createCasing); | ||
PREP(createMagazine); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,60 @@ | ||
#include "..\script_component.hpp" | ||
/* | ||
* Author: GabrielPearce / esteldunedain / Cyruz / diwako / PabstMirror | ||
* Produces a casing matching the reloaded and dropped magazine | ||
* | ||
* Arguments: | ||
* 0: unit - Object the event handler is assigned to <OBJECT> | ||
* 4: Old magazine (can be nil) - <ARRAY> | ||
* | ||
* Return Value: | ||
* None | ||
* | ||
* Example: | ||
* [player, "", "","", ["1Rnd_HE_Grenade_shell", 0]] call ace_casings_fnc_createMagazine | ||
* | ||
* Public: No | ||
*/ | ||
|
||
params ["_unit", "", "", "", "_oldMagazine"]; | ||
TRACE_2("createMagazine",_unit,_oldMagazine); | ||
|
||
if (isNil "_oldMagazine") exitWith {}; | ||
_oldMagazine params ["_mag", "_ammo"]; | ||
if (_ammo != 0) exitWith {}; | ||
|
||
private _modelPath = GVAR(cachedMagazines) getOrDefaultCall [_mag, { | ||
switch (true) do { | ||
// Should cover most 40x36 | ||
case (_mag in compatibleMagazines ["arifle_Mk20_GL_F", "EGLM"]): { "A3\Weapons_F\MagazineProxies\mag_40x36_HE_1rnd.p3d" }; | ||
default { getText (configFile >> "CfgMagazines" >> _mag >> QGVAR(model)) }; | ||
}; | ||
}, true]; | ||
|
||
if (_modelPath isEqualTo "") exitWith {}; | ||
|
||
private _unitPos = getposASL _unit; | ||
Check notice on line 36 in addons/casings/functions/fnc_createMagazine.sqf GitHub Actions / windows`getposASL` does not match the wiki's case
|
||
private _weapDir = _unit weaponDirection currentWeapon _unit; | ||
private _ejectDir = _weapDir vectorCrossProduct [0, 0, 1]; | ||
private _pos = _unitPos | ||
vectorAdd (_weapDir vectorMultiply (-0.5 + random 2)) | ||
vectorAdd (_ejectDir vectorMultiply (0.2 + random 2)); | ||
|
||
[ | ||
{ | ||
params ["_modelPath", "_pos"]; | ||
TRACE_2("creating magazine",_modelPath,_pos); | ||
|
||
private _lisPos = (lineIntersectsSurfaces [_pos, _pos vectorAdd [0,0,-1e11], objNull, objNull, true, 1, "ROADWAY", "FIRE"]) #0; | ||
private _casing = createSimpleObject [_modelPath, (_lisPos #0 vectorAdd [0,0,0.010]), false]; // global | ||
_casing setDir (random 360); | ||
_casing setVectorUp _lisPos #1; | ||
private _idx = GVAR(casings) pushBack _casing; | ||
|
||
for "_" from 0 to (_idx - GVAR(maxCasings)) do { | ||
deleteVehicle (GVAR(casings) deleteAt 0); | ||
}; | ||
}, | ||
[_modelPath,_pos], | ||
0.4 | ||
] call CBA_fnc_waitAndExecute; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe pull from magProxy and override with this if available?