Hero Image Done #79
Hero Image Done #79
Conversation
|
|
There was a problem hiding this comment.
Let me know if these changes work: i tested it out and should be alright! But what we are doing is adjusting the outer div (that contains the assets) to be the same width as the hero card so that it will be in the same position. Don't worry about the mobile responsiveness for it right now, that will be later issue.
| const Hero = () => { | ||
| return ( | ||
| <div className=""> | ||
| <div className="relative"> |
There was a problem hiding this comment.
no need relative here (delete the classname)
| const Hero = () => { | ||
| return ( | ||
| <div className=""> | ||
| <div className="relative"> | ||
| <div className="relative"> |
There was a problem hiding this comment.
for this outer div: add mx-auto + w-2/5 (then change the herocard's w: instead of max-w-xl --> w-2/5)
| <div className="relative"> | ||
| <div className="relative"> | ||
| <Image | ||
| className="absolute -bottom-56 left-64 z-10 transform" |
There was a problem hiding this comment.
change left-64 to -left-36, so it is consistent with "-bottom-56"
| alt="hero border component" | ||
| /> | ||
| <Image | ||
| className="absolute right-64 top-8 z-10 scale-x-[-1] scale-y-[-1] transform" |
There was a problem hiding this comment.
then change right-64 to -right-36
There was a problem hiding this comment.
All the changes worked. What do I do now though? Do I repush the changes?
There was a problem hiding this comment.
Okie great! Just push the same way you did before, on the same branch that you initially pushed for on this issue. It will just auto update the code from before :D
There was a problem hiding this comment.
Ok sweet, will do!
There was a problem hiding this comment.
Wait sorry something weird is happening where whenever I commit, it commits to Hero Font and not Hero Image. Is that a problem?
Finished adding the little border images.