Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Header Fonts #89

Merged
merged 4 commits into from
Feb 16, 2025
Merged

Fixed Header Fonts #89

merged 4 commits into from
Feb 16, 2025
+9 −7

Conversation

akothule
Copy link
Collaborator

Screenshot 2025-02-11 at 7 50 20 PM

@akothule akothule self-assigned this Feb 12, 2025
@akothule akothule linked an issue Feb 12, 2025 that may be closed by this pull request
Fix Header Fonts #64
Closed
arieen17
arieen17 previously approved these changes Feb 12, 2025
View reviewed changes
Copy link
Contributor

@arieen17 arieen17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

@arieen17 arieen17 dismissed their stale review February 12, 2025 19:39

merge conflicts!

tingtingtingtingtingtingtingtingtingtin
tingtingtingtingtingtingtingtingtingtin requested changes Feb 14, 2025
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! make this change and remember to change the label to "Ready to review"

src/components/Header.tsx Outdated Show resolved Hide resolved
@akothule @tingtingtingtingtingtingtingtingtingtin
Update src/components/Header.tsx
1a684d2 
Co-authored-by: Ting Wu <115962958+tingtingtingtingtingtingtingtingtingtin@users.noreply.github.com>
@tingtingtingtingtingtingtingtingtingtin tingtingtingtingtingtingtingtingtingtin merged commit 0f4e897 into dev Feb 16, 2025
5 checks passed
@tingtingtingtingtingtingtingtingtingtin tingtingtingtingtingtingtingtingtingtin deleted the akothule/HeaderFonts branch February 16, 2025 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tingtingtingtingtingtingtingtingtingtin tingtingtingtingtingtingtingtingtingtin tingtingtingtingtingtingtingtingtingtin approved these changes

@arieen17 arieen17 arieen17 left review comments

Assignees

@akothule akothule

Labels
Ready for Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix Header Fonts
3 participants
@akothule @tingtingtingtingtingtingtingtingtingtin @arieen17