Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed navigation Bar #90

Merged
merged 7 commits into from
Feb 18, 2025
Merged

Fixed navigation Bar #90

merged 7 commits into from
Feb 18, 2025

Conversation

daniyalbhat34
Copy link
Collaborator

Screenshot (545)

@daniyalbhat34 daniyalbhat34 self-assigned this Feb 12, 2025
@daniyalbhat34 daniyalbhat34 linked an issue Feb 12, 2025 that may be closed by this pull request
@arieen17
Copy link
Contributor

For the navigation bar (it is a bit complex so ask for help or if you are unable to do this!), we are going to use mapping (which we went over in the last meeting). So create a data folder (if not yet created) then a file for the navigation where we would list all the different labels in the navbar + links.

For the tracking (use: usePathname): when we are on a specific page like "Events" there will be a tracking indicator that we are on that specific page (can use the underline as indicator)
Here is how CSA (a current project) was able to do it: https://github.com/acm-ucr/csa-website/blob/dev/src/components/NavBar.tsx

Do not worry about the mobile responsive for now just get the navbar set up with mapping + tracking!

@daniyalbhat34
Copy link
Collaborator Author

Screenshot (546)

Copy link
Contributor

@arieen17 arieen17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!

@arieen17 arieen17 merged commit 54c0f20 into dev Feb 18, 2025
5 checks passed
@arieen17 arieen17 deleted the daniyal/editNavBar branch February 18, 2025 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Navbar fix
2 participants