Skip to content

Commit

Permalink
Avoid permissions errors for chown .well-known
Browse files Browse the repository at this point in the history
When acme.sh is run as a non-root user different from the owner of the
webroot directory it is unable to change the owner of the files in
.well-known to that user, causing permissions errors.  Avoid this by
making the files world-readable.

These files should pose no disclosure risk since they are sent in
cleartext during the HTTP Identifier Validation Challenge[1] and may
already be exposed by directory enumeration, depending on server
settings.  AFAIK they should be safe to expose as world-readable in all
cases.

1.  https://ietf-wg-acme.github.io/acme/#rfc.section.7.2

Fixes #32
Signed-off-by: Kevin Locke <[email protected]>
  • Loading branch information
kevinoid committed Jul 29, 2017
1 parent a6a0495 commit bf6a0e6
Showing 1 changed file with 5 additions and 15 deletions.
20 changes: 5 additions & 15 deletions acme.sh
Original file line number Diff line number Diff line change
Expand Up @@ -3679,28 +3679,18 @@ issue() {

_debug "writing token:$token to $wellknown_path/$token"

mkdir -p "$wellknown_path"

if ! printf "%s" "$keyauthorization" >"$wellknown_path/$token"; then
# Ensure .well-known is visible to web server user/group
# https://github.com/Neilpang/acme.sh/pull/32
if ! (umask ugo+rx \
&& mkdir -p "$wellknown_path" \
&& printf "%s" "$keyauthorization" >"$wellknown_path/$token"); then
_err "$d:Can not write token to file : $wellknown_path/$token"
_clearupwebbroot "$_currentRoot" "$removelevel" "$token"
_clearup
_on_issue_err "$_post_hook" "$vlist"
return 1
fi

if [ ! "$usingApache" ]; then
if webroot_owner=$(_stat "$_currentRoot"); then
_debug "Changing owner/group of .well-known to $webroot_owner"
if ! _exec "chown -R \"$webroot_owner\" \"$_currentRoot/.well-known\""; then
_debug "$(cat "$_EXEC_TEMP_ERR")"
_exec_err >/dev/null 2>&1
fi
else
_debug "not changing owner/group of webroot"
fi
fi

fi

elif [ "$vtype" = "$VTYPE_TLS" ]; then
Expand Down

0 comments on commit bf6a0e6

Please sign in to comment.