Acme2 similar names #4855
Merged
Acme2 similar names #4855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… proper root domain to add challenge records in
|
Welcome |
I did read the guides, and setup the test to run. As I am making a 1 line change to an existing file, the Dev Guide didn't apply for what I'm trying to do, but I did indeed read it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #1628 I experienced an issue with having multiple similar Hosted Zones within AWS, causing acme.sh to try to use the wrong Zone to renew a certificate, and specifically to fail setting the ACME challenge DNS entry. From looking through the code for just this provider, and testing locally, I was able to add just this bit to escape Periods for the domain name part of the string passed into _egrep_o, without affecting anything else.