Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2 Bugfixes of dns_dynv6.sh: 1. domains containing 'id' are now working as intended and 2. hostnames are now cast to lowercase on the fly #5218

Merged
merged 5 commits into from
Sep 15, 2024
Prev Previous commit
Next Next commit
Fixed a bug where trying to add entries where the fulldomain contains…
… upper case characters would not be accepted (dynv6 API rejects those).

Now the fulldomain will be cast to lowercase first which should not make
any difference since DNS is case insensitive.
  • Loading branch information
Felix Schmidt committed Jul 7, 2024
commit a2bc79ddd51c6ecdd831a105530ad5e8618ff346
8 changes: 4 additions & 4 deletions dnsapi/dns_dynv6.sh
Original file line number Diff line number Diff line change
@@ -16,8 +16,8 @@ dynv6_api="https://dynv6.com/api/v2"
# Please Read this guide first: https://github.com/Neilpang/acme.sh/wiki/DNS-API-Dev-Guide
#Usage: dns_dynv6_add _acme-challenge.www.domain.com "XKrxpRBosdIKFzxW_CT3KLZNf6q0HG9i01zxXp5CPBs"
dns_dynv6_add() {
fulldomain=$1
txtvalue=$2
fulldomain=$(echo "$1" | tr 'A-Z' 'a-z')
txtvalue="$2"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use _lower_case()

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I overlooked the existence of that function but this is changed now.

Also thanks for the quick response!

_info "Using dynv6 api"
_debug fulldomain "$fulldomain"
_debug txtvalue "$txtvalue"
@@ -50,8 +50,8 @@ dns_dynv6_add() {
#Usage: fulldomain txtvalue
#Remove the txt record after validation.
dns_dynv6_rm() {
fulldomain=$1
txtvalue=$2
fulldomain=$(echo "$1" | tr 'A-Z' 'a-z')
txtvalue="$2"
_info "Using dynv6 API"
_debug fulldomain "$fulldomain"
_debug txtvalue "$txtvalue"