-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for mijn.host DNS challenge #5287
base: dev
Are you sure you want to change the base?
Conversation
Welcome |
@Neilpang do you have time to review this PR? |
Any progress on this? |
I guess you need to enable Github Actions on your Forked repo first, and then push code to your repo, it will run there. Like the page states. I'd like to see mijn.host added as well, so I appreciate your efforts. |
@shubhamku044 can you follow up on this ? |
Is it done? @ualex73 |
Nope. Tests run but fail. Not sure why, since your script is fine standalone. I've asked for a bit of support in my pull request. |
No, I was not working on this. I just like to see it included, then I can switch to mijn.host with my domains. |
I am also trying to add a new provider and am currently a bit further along than you. Maybe we can help each other. Shellcheck throws an error because you do not quote your variables with “. See also https://github.com/acmesh-official/acme.sh/wiki/Code-of-conduct#style-guidelines and compare my script https://github.com/baerengraben/acme.sh/blob/master/dnsapi/dns_hosttech.sh but be forewarned: if this check is ok, I'm curious to see if your workflow goes through. That's where it's currently failing for me. |
No description provided.