Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates dns_cyon txt_body and adds validation #6097

Closed
wants to merge 3 commits into from

Conversation

InteractiveNinja
Copy link

Hello!

I recently attempted to update my domains certificate via acme.sh, but encountered issues with the txt validation.
After some debugging, I found at that the form body had changed a little.

Changes

zone ➡️ name
value ➡️ dnscontent

I also added a validation for the response being returned after the update, in hopes that it will actually bail if the update fails.
I didn't try it, but I think it should work.

Thanks for this great tool, and also thanks for maintaining support for cyon domains 👍

Copy link

Welcome
First thing: don't send PR to the master branch, please send to the dev branch instead.
Please make sure you've read our DNS API Dev Guide and DNS-API-Test.
Then reply on this message, otherwise, your code will not be reviewed or merged.
We look forward to reviewing your Pull request shortly ✨
注意: 必须通过了 DNS-API-Test 才会被 review. 无论是修改, 还是新加的 dns api, 都必须确保通过这个测试.

@InteractiveNinja InteractiveNinja closed this by deleting the head repository Nov 14, 2024
@mikch06
Copy link

mikch06 commented Dec 11, 2024

That's the issue!
Thx a lot!

@dedors
Copy link

dedors commented Dec 11, 2024

Waiting for this too, hope will get merged soon.
In the meantime, it's possible to add the TXT record manually.

@mikch06
Copy link

mikch06 commented Dec 12, 2024

Waiting for this too, hope will get merged soon. In the meantime, it's possible to add the TXT record manually.

You can change the dns_cyon.sh plugin on your own side until the fix is merged:
/root/.acme.sh/dnsapi/dns_cyon.sh

worked fine for me.

@mike4054
Copy link

mike4054 commented Jan 3, 2025

I'm waiting for that update too but I see this is closed now. Any chance that this will make it to the release somewhen?

@JazzMalar JazzMalar mentioned this pull request Jan 3, 2025
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants