Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ZoneEdit.com #6136

Merged
merged 1 commit into from
Dec 9, 2024
Merged

Add support for ZoneEdit.com #6136

merged 1 commit into from
Dec 9, 2024

Conversation

lukavia
Copy link
Contributor

@lukavia lukavia commented Dec 6, 2024

This merges the work of https://github.com/blueslow/sslcertzoneedit

I've been using it for years without an issue and I think I followed all the guides to make it part of this wonderful project.

The action in my fork passed all the checks.

Copy link

github-actions bot commented Dec 6, 2024

Welcome
First thing: don't send PR to the master branch, please send to the dev branch instead.
Please make sure you've read our DNS API Dev Guide and DNS-API-Test.
Then reply on this message, otherwise, your code will not be reviewed or merged.
We look forward to reviewing your Pull request shortly ✨
注意: 必须通过了 DNS-API-Test 才会被 review. 无论是修改, 还是新加的 dns api, 都必须确保通过这个测试.

@lukavia
Copy link
Contributor Author

lukavia commented Dec 6, 2024

Welcome First thing: don't send PR to the master branch, please send to the dev branch instead. Please make sure you've read our DNS API Dev Guide and DNS-API-Test. Then reply on this message, otherwise, your code will not be reviewed or merged. We look forward to reviewing your Pull request shortly ✨ 注意: 必须通过了 DNS-API-Test 才会被 review. 无论是修改, 还是新加的 dns api, 都必须确保通过这个测试.

Yes. I've read the Guide and the tests passed in my fork

@Neilpang
Copy link
Member

Neilpang commented Dec 7, 2024

please add the usage here:
https://github.com/acmesh-official/acme.sh/wiki/dnsapi2

@lukavia
Copy link
Contributor Author

lukavia commented Dec 7, 2024

please add the usage here: https://github.com/acmesh-official/acme.sh/wiki/dnsapi2

I've provided more information for the usage and the origin of the plugin. Hope it is more clear now.

Sorry

@Neilpang Neilpang merged commit 2997a15 into acmesh-official:dev Dec 9, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants